Linux wireless drivers development
 help / color / mirror / Atom feed
From: Luka Gejak <luka.gejak@linux.dev>
To: "David Härdeman" <david@hardeman.nu>,
	"Ping-Ke Shih" <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Leonard Lausen <leonard@lausen.nl>,
	Alastair D'Silva <alastair@d-silva.org>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Bitterblue Smith <rtl8821cerfe2@gmail.com>
Subject: Re: [PATCH rtw-next 0/5] wifi: rtw88: sdio: faster and fairer TX for the 88xx chips
Date: Tue, 17 Nov 2026 16:27:28 +0100	[thread overview]
Message-ID: <03BBDDF6-2ACB-4B06-827D-69811DF5664A@linux.dev> (raw)
In-Reply-To: <avxoWTaI2G8aklLk@hardeman.nu>

Hi David,

Thanks for your explanation, here is my two cents.

On November 17, 2026 3:44:41 PM GMT+01:00, "David Härdeman"
<david@hardeman.nu> wrote:

> I did use a second AP as a sniffer, but it was too far from the R76S to
> decode its VHT data frames. It did see the client's BAs, and no BAR from
> the AP.

I think the closer capture would still help, with the data frames and BA
bitmap for the same TID around a scan. The client trace shows what its
firmware passed up, and the per MACID failure count does not identify
which MPDU failed. Matching those to the air capture would help check
what happened to the particular hole.

[ ... ]

> From what I understand, mac80211 can, but only if the driver tells it
> which frame was dropped: the driver reports that frame as not acked,
> with IEEE80211_TX_STAT_AMPDU_NO_BACK set, and mac80211 then sends a BAR
> with SSN = SN + 1 (see net/mac80211/status.c).

I checked the mac80211 status path, and it does send a BAR with the next
sequence number for that QoS status. The current rtw88 report helper does
not set AMPDU_NO_BACK, so requesting the reports alone would not exercise
that recovery path.

[ ... ]

> I tried requesting that report for every QoS data frame: only about 7 %
> of the requests were answered, roughly one per A-MPDU, and download
> throughput dropped by about a third (~210 to ~140 Mbit/s). So per-frame
> reports don't seem usable for this. A report that only covers the
> dropped frames, with their SN, would be enough.

One detail that might affect this experiment is that the sn passed to
rtw_tx_report_enqueue() is a report cookie, rather than the frame's
802.11 sequence number. It has six usable bits:

        pkt_info->sn = (atomic_inc_return(&tx_report->sn) << 2) & 0xfc;

As far as I can see, it repeats after 64 requests, and
rtw_tx_report_handle() takes the first skb with a matching cookie. If an
older request is still pending when its cookie is reused, a report for
the newer frame can complete the older skb.

Was the 7% figure from raw C2H events or from completed skbs? This would
affect frame attribution, but would not explain a shortage of raw C2H
events. Maybe a short run with one request outstanding at a time,
logging the cookie, QoS TID and seq_ctrl, would help check that part.

Best regards,
Luka Gejak

      reply	other threads:[~2026-11-17 15:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 19:01 [PATCH rtw-next 0/5] wifi: rtw88: sdio: faster and fairer TX for the 88xx chips David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 1/5] wifi: rtw88: sdio: cache the free TX page counts of " David Härdeman
2026-11-17  7:20   ` Luka Gejak
2026-11-17 12:50     ` David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 2/5] wifi: rtw88: sdio: aggregate TX frames " David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 3/5] wifi: rtw88: sdio: limit the TX queue length " David Härdeman
2026-11-17  7:21   ` Luka Gejak
2026-11-17 12:57     ` David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 4/5] wifi: rtw88: sdio: let TX in while receiving on " David Härdeman
2026-11-16 19:01 ` [PATCH rtw-next 5/5] wifi: rtw88: sdio: read neighbouring registers of the 88xx chips at once David Härdeman
2026-11-16 21:59 ` [PATCH rtw-next 0/5] wifi: rtw88: sdio: faster and fairer TX for the 88xx chips Luka Gejak
2026-11-17  7:46 ` Ping-Ke Shih
2026-11-17 14:44   ` David Härdeman
2026-11-17 15:27     ` Luka Gejak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03BBDDF6-2ACB-4B06-827D-69811DF5664A@linux.dev \
    --to=luka.gejak@linux.dev \
    --cc=alastair@d-silva.org \
    --cc=david@hardeman.nu \
    --cc=jernej.skrabec@gmail.com \
    --cc=leonard@lausen.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=pkshih@realtek.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox