From: "voncken" <cedric.voncken@acksys.fr>
To: "'Johannes Berg'" <johannes@sipsolutions.net>
Cc: <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH] wireless: vlan priority handling in WMM
Date: Wed, 26 Jun 2013 11:36:13 +0200 [thread overview]
Message-ID: <059a01ce7250$9980fa80$cc82ef80$@acksys.fr> (raw)
In-Reply-To: <1372232028.8157.1.camel@jlt4.sipsolutions.net>
>>On Tue, 2013-06-25 at 17:31 +0200, cedric.voncken@acksys.fr wrote:
>> From: Cedric Voncken <cedric.voncken@acksys.fr>
>>
>> If the VLAN priority is set in skb->vlan_tci use it to determine the WMM priority.
>What's the VLAN priority? How are you even running 802.1q on top of wifi? heh.
I used the wireless as bridge (The wireless vif client is bridged with my eth0). The VLAN tag is already present in frame when I received it from eth0. The eth0 driver set the skb->vlan_tci.
>> @@ -694,6 +695,10 @@ unsigned int cfg80211_classify8021d(struct sk_buff *skb)
>> if (skb->priority >= 256 && skb->priority <= 263)
>> return skb->priority - 256;
>>
>> + vlan_priority = (skb->vlan_tci >> 13) & 0x07;
>Are there no symbolic constants for this?
Fix in V2
>> + if (vlan_priority > 0)
>> + return vlan_priority;
>I think you got indentation a bit confused :-)
Sorry, it will fix in V2.
Cedric
prev parent reply other threads:[~2013-06-26 9:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-25 15:31 [PATCH] wireless: vlan priority handling in WMM cedric.voncken
2013-06-26 7:33 ` Johannes Berg
2013-06-26 9:36 ` voncken [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='059a01ce7250$9980fa80$cc82ef80$@acksys.fr' \
--to=cedric.voncken@acksys.fr \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).