From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Johannes Berg <johannes@sipsolutions.net>,
Jouni Malinen <jouni@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, "Kanchanapally,
Vidyullatha" <vkanchan@qti.qualcomm.com>
Subject: Re: [RFC] cfg80211: Add support for FILS shared key authentication offload
Date: Sun, 5 Mar 2017 20:20:05 +0100 [thread overview]
Message-ID: <078be4ec-c3d1-cde9-3032-d31349db5fe5@broadcom.com> (raw)
In-Reply-To: <1488544081.25750.5.camel@sipsolutions.net>
On 3-3-2017 13:28, Johannes Berg wrote:
>> +void cfg80211_connect_done(struct net_device *dev, const u8 *bssid,
>> + struct cfg80211_bss *bss, const u8
>> *req_ie,
>> + size_t req_ie_len, const u8 *resp_ie,
>> + size_t resp_ie_len, const u8 *fils_kek,
>> + size_t fils_kek_len, bool
>> update_erp_seq_num,
>> + u16 fils_erp_seq_num, const u8 *pmk,
>> size_t pmk_len,
>> + const u8 *pmkid, int status, gfp_t gfp,
>> + enum nl80211_timeout_reason
>> timeout_reason);
> Ouch. Please declare most of those (perhaps other than dev) as a
> structure and pass a pointer here.
>
> Also, why require the BSSID when BSS is set? Seems you could say one or
> the other.
The BSSID/BSS behaviour is already present in current
cfg80211_connect_bss(). bss may be NULL which will result in lookup
using the given bssid.
Regards,
Arend
prev parent reply other threads:[~2017-03-05 19:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 11:53 [RFC] cfg80211: Add support for FILS shared key authentication offload Jouni Malinen
2017-03-03 12:28 ` Johannes Berg
2017-03-05 19:20 ` Arend Van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=078be4ec-c3d1-cde9-3032-d31349db5fe5@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vkanchan@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox