From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A46C433E0 for ; Mon, 4 Jan 2021 13:55:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 996E2207B1 for ; Mon, 4 Jan 2021 13:55:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726586AbhADNzW (ORCPT ); Mon, 4 Jan 2021 08:55:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726328AbhADNzW (ORCPT ); Mon, 4 Jan 2021 08:55:22 -0500 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D885C061793 for ; Mon, 4 Jan 2021 05:54:41 -0800 (PST) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94) (envelope-from ) id 1kwQJ1-001Vd8-GB; Mon, 04 Jan 2021 14:54:34 +0100 Message-ID: <097b8ea0c643c8372f1a57499969d7a96b1542bd.camel@sipsolutions.net> Subject: Re: [PATCH mac80211-next] mac80211: introduce aql_enable node in debugfs From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= , Lorenzo Bianconi Cc: Lorenzo Bianconi , linux-wireless , kyan@google.com Date: Mon, 04 Jan 2021 14:54:17 +0100 In-Reply-To: <87pn2k4xw1.fsf@toke.dk> References: <0ad278def3875fc2c60b4898daa3f0d53288c168.1608975795.git.lorenzo@kernel.org> <87y2h8525a.fsf@toke.dk> <87pn2k4xw1.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, 2021-01-04 at 14:47 +0100, Toke Høiland-Jørgensen wrote: > Lorenzo Bianconi writes: > > > > Lorenzo Bianconi writes: > > > > > > > Introduce aql_enable node in debugfs in order to enable/disable aql. > > > > This is useful for debugging purpose. > > > > > > Don't mind having a switch, although I wonder if it would be better to > > > overload the existing debugfs file (e.g., a threshold of 0 could disable > > > everything?) so as not to clutter up debugfs too much? > > > > > > -Toke > > > > > > > You mean to consider 0 as a special value to disable aql, right? I > > would prefer to have a dedicated switch for it since I guess it is > > clearer for users (but I can live with it :) ) > > Yeah, maybe a bit clearer but at the cost of clutter. I dunno, not a > strong preference either way; I guess Johannes can make the call :) I'm not sure I care about an extra debugfs file - but I do wonder about the extra check at runtime that would basically never be true since the default is enable ... Maybe that should use a static_branch() or something? johannes