From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga11.intel.com ([192.55.52.93]:35814 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752167AbaJFMsG convert rfc822-to-8bit (ORCPT ); Mon, 6 Oct 2014 08:48:06 -0400 From: "Grumbach, Emmanuel" To: Seth Forshee CC: "linux-wireless@vger.kernel.org" Subject: RE: [RFT] iwlwifi: dvm: drop non VO frames when flushing Date: Mon, 6 Oct 2014 12:47:41 +0000 Message-ID: <0BA3FCBA62E2DC44AF3030971E174FB31B53CC1F@hasmsx107.ger.corp.intel.com> (sfid-20141006_144811_649363_9DBAF47D) References: <1412517432-16309-1-git-send-email-emmanuel.grumbach@intel.com> <20141006123314.GA131459@ubuntu-hedt> <0BA3FCBA62E2DC44AF3030971E174FB31B53CBD4@hasmsx107.ger.corp.intel.com> <20141006124307.GB131459@ubuntu-hedt> <20141006124402.GC131459@ubuntu-hedt> In-Reply-To: <20141006124402.GC131459@ubuntu-hedt> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: > > On Mon, Oct 06, 2014 at 07:43:07AM -0500, Seth Forshee wrote: > > On Mon, Oct 06, 2014 at 12:35:46PM +0000, Grumbach, Emmanuel wrote: > > > > Subject: Re: [RFT] iwlwifi: dvm: drop non VO frames when flushing > > > > > > > > On Sun, Oct 05, 2014 at 04:57:12PM +0300, Emmanuel Grumbach wrote: > > > > > + if (vif) > > > > > + scd_queues &= ~BIT(vif- > >hw_queue[IEEE80211_AC_VO]); > > > > > > > > I'm backporting this to 3.13, and this part doesn't work unless > > > > 77be2c54c5bd26279abc13807398771d80cda37a is also backported. Is > > > > this critical, or can it be omitted in the backport? > > > > > > > > > > 77be2c54c5bd26279abc13807398771d80cda37a isn't really critical, but it is > a dependency, and it is safe IMO. > > > But I'd wait for a bit more testing :) The patch isn't even in my > > > tree yet :) > > > > My backport is for testing too. Most of our bugs are against Ubuntu > > 14.04, which uses 3.13. Seems better to have them test this change in > > isolation rather than also testing everything which has changed up to > > 3.17. > > > > I agree the patch is safe, > > Sorry, I was ambiguous here. I mean that > 77be2c54c5bd26279abc13807398771d80cda37a is safe to backport. > > > but I'd also prefer to have it tested in the form which would > > eventually get applied to the 3.13 extended stable tree. So I take it > > for stable you would advocate applying both patches? I guess... I can rework the discussed patch (drop non VO ...) to work without 77be2c54c5bd26279abc13807398771d80cda37a, but is it really worth it? I don't see any reason not to backport 77be2c54c5bd26279abc13807398771d80cda37a. IMHO, the easiest is to backport 77be2c54c5bd26279abc13807398771d80cda37a and apply the drop non VO on top of it. What am I missing?