From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC45AC433B4 for ; Fri, 21 May 2021 00:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C76AE61363 for ; Fri, 21 May 2021 00:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235562AbhEUAvH (ORCPT ); Thu, 20 May 2021 20:51:07 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:3634 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235556AbhEUAvH (ORCPT ); Thu, 20 May 2021 20:51:07 -0400 Received: from dggems706-chm.china.huawei.com (unknown [172.30.72.60]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4FmScZ5Hk2zmWjv; Fri, 21 May 2021 08:47:26 +0800 (CST) Received: from dggeme759-chm.china.huawei.com (10.3.19.105) by dggems706-chm.china.huawei.com (10.3.19.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 21 May 2021 08:49:43 +0800 Received: from [127.0.0.1] (10.40.188.144) by dggeme759-chm.china.huawei.com (10.3.19.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 21 May 2021 08:49:43 +0800 Subject: Re: [PATCH] ssb: remove unreachable code To: =?UTF-8?Q?Michael_B=c3=bcsch?= , Tian Tao CC: , Kalle Valo References: <1621306352-3632-1-git-send-email-tiantao6@hisilicon.com> <20210520185136.2cc3b32b@wiggum> From: "tiantao (H)" Message-ID: <0a40049b-691c-c75f-ece2-a669842bedaf@huawei.com> Date: Fri, 21 May 2021 08:49:42 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20210520185136.2cc3b32b@wiggum> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.40.188.144] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggeme759-chm.china.huawei.com (10.3.19.105) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org 在 2021/5/21 0:51, Michael Büsch 写道: > On Tue, 18 May 2021 10:52:32 +0800 > Tian Tao wrote: > >> The return value of ssb_bus_unregister can only be 0 or 1, so this >> condition if (err == -EBUSY) will not hold, so delete it. >> @@ -431,9 +431,7 @@ void ssb_bus_unregister(struct ssb_bus *bus) >> int err; >> >> err = ssb_gpio_unregister(bus); >> - if (err == -EBUSY) >> - pr_debug("Some GPIOs are still in use\n"); >> - else if (err) >> + if (err) >> pr_debug("Can not unregister GPIO driver: %i\n", err); >> >> ssb_buses_lock(); > Good catch. > Minor correction: The return value can be 0 or -1. yes, you are right. thanks again.:-) > > Acked-by: Michael Büsch >