From: Johannes Berg <johannes@sipsolutions.net>
To: Len Brown <lenb@kernel.org>, Luca Coelho <luciano.coelho@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: iwlwifi 0000:3a:00.0: Microcode SW error detected. Restarting 0x2000000.
Date: Wed, 12 Jan 2022 09:34:35 +0100 [thread overview]
Message-ID: <0bb2a3b794c19514ad30ecc0ca60d1d6e9e438b0.camel@sipsolutions.net> (raw)
In-Reply-To: <CAJvTdKm9PQrnyEG=b-8DbdnOHup8Ec6VqoKp3ZCQXwmvXU3FbA@mail.gmail.com>
On Tue, 2022-01-11 at 20:47 -0500, Len Brown wrote:
>
> I recently installed Fedora 35, and the card worked fine.
> But when I built and booted a 5.15 or 5.16 upstream kernel from src,
> the card fails at initialization and I've not found a way to revive it.
> (dmesg below)
Ouch.
> [ 11.411533] iwlwifi 0000:3a:00.0: Loaded firmware version: 17.3216344376.0 3160-17.ucode
> [ 11.412815] iwlwifi 0000:3a:00.0: 0x00000038 | BAD_COMMAND
...
> [ 11.688317] iwlwifi 0000:3a:00.0: FW error in SYNC CMD PER_CHAIN_LIMIT_OFFSET_CMD
Looks like somehow this slipped through and we're sending a new command
with an old firmware.
Something like this might help?
diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 7ee4802a5ef1..56b9363a9111 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -1026,7 +1026,9 @@ static int iwl_mvm_sar_geo_init(struct iwl_mvm *mvm)
/* the ops field is at the same spot for all versions, so set in v1 */
cmd.v1.ops = cpu_to_le32(IWL_PER_CHAIN_OFFSET_SET_TABLES);
- if (cmd_ver == 5) {
+ if (cmd_ver == IWL_FW_CMD_VER_UNKNOWN) {
+ return 0;
+ } else if (cmd_ver == 5) {
len = sizeof(cmd.v5);
n_bands = ARRAY_SIZE(cmd.v5.table[0]);
n_profiles = ACPI_NUM_GEO_PROFILES_REV3;
Luca, are you aware of anything in this area?
johannes
next prev parent reply other threads:[~2022-01-12 8:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 1:47 iwlwifi 0000:3a:00.0: Microcode SW error detected. Restarting 0x2000000 Len Brown
2022-01-12 8:34 ` Johannes Berg [this message]
2022-01-12 9:05 ` Coelho, Luciano
2022-01-12 9:27 ` Johannes Berg
2022-01-12 9:33 ` Coelho, Luciano
2022-01-12 9:35 ` Johannes Berg
2022-01-12 9:40 ` Coelho, Luciano
2022-01-12 14:58 ` Len Brown
2022-01-12 15:42 ` Coelho, Luciano
2022-01-12 18:14 ` Len Brown
2022-01-12 18:49 ` Len Brown
2022-01-13 8:51 ` Coelho, Luciano
2022-01-27 18:28 ` Coelho, Luciano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bb2a3b794c19514ad30ecc0ca60d1d6e9e438b0.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=lenb@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luciano.coelho@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox