From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: Ping-Ke Shih <pkshih@realtek.com>
Subject: [PATCH] wifi: rtlwifi: pci: Fix condition to wake the queues
Date: Tue, 18 Feb 2025 23:42:26 +0200 [thread overview]
Message-ID: <0c91ac77-a652-4ab4-b911-e0a2386fb863@gmail.com> (raw)
The TX queues should be woken when there are at least 4 available
entries, not when there are at most 4.
Tested with RTL8821AE.
Fixes: d0311314d002 ("rtlwifi: rtl8192ee: Fix handling of new style descriptors")
Cc: stable@vger.kernel.org
Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
---
drivers/net/wireless/realtek/rtlwifi/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wireless/realtek/rtlwifi/pci.c
index 0eafc4d125f9..9614a9e752b9 100644
--- a/drivers/net/wireless/realtek/rtlwifi/pci.c
+++ b/drivers/net/wireless/realtek/rtlwifi/pci.c
@@ -520,7 +520,7 @@ static void _rtl_pci_tx_isr(struct ieee80211_hw *hw, int prio)
rtl_tx_ackqueue(hw, skb);
}
- if ((ring->entries - skb_queue_len(&ring->queue)) <= 4) {
+ if ((ring->entries - skb_queue_len(&ring->queue)) >= 4) {
rtl_dbg(rtlpriv, COMP_ERR, DBG_DMESG,
"more desc left, wake skb_queue@%d, ring->idx = %d, skb_queue_len = 0x%x\n",
prio, ring->idx,
--
2.48.1
next reply other threads:[~2025-02-18 21:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 21:42 Bitterblue Smith [this message]
2025-02-19 6:20 ` [PATCH] wifi: rtlwifi: pci: Fix condition to wake the queues Ping-Ke Shih
2025-02-26 22:50 ` Bitterblue Smith
2025-02-27 0:49 ` Ping-Ke Shih
2025-02-26 1:47 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c91ac77-a652-4ab4-b911-e0a2386fb863@gmail.com \
--to=rtl8821cerfe2@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox