From: Johannes Berg <johannes@sipsolutions.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Miller <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
John Crispin <john@phrozen.org>
Subject: Re: pull-request: mac80211-next 2019-07-31
Date: Mon, 28 Oct 2019 12:38:29 +0100 [thread overview]
Message-ID: <0e6c13812faa01026b55d64c1af500eda048b759.camel@sipsolutions.net> (raw)
In-Reply-To: <c062695f8d05a4c36a6d69f421b05208ac51fd2c.camel@sipsolutions.net> (sfid-20191028_120835_987215_F3E3F93B)
On Mon, 2019-10-28 at 12:08 +0100, Johannes Berg wrote:
> On Mon, 2019-10-28 at 11:53 +0100, Arnd Bergmann wrote:
> > > Why do you say 32-bit btw, it should be *bigger* on 64-bit, but I didn't
> > > see this ... hmm.
> >
> > That is correct. For historic reasons, both the total amount of stack space
> > per thread and the warning limit on 64 bit are twice the amount that we
> > have on 32-bit kernels, so even though the problem is more serious on
> > 64-bit architectures, we do not see a warning about it because we remain
> > well under the warning limit.
>
> Hmm, but I have:
>
> CONFIG_FRAME_WARN=1024
>
> in my compilation
But the compiler decides not to inline it, for whatever reason. Only if
I mark it as __always_inline, does it actually inline it.
But it does seem to merge the storage, if I inline only assoc_success()
I get 888 bytes (after the fix), if I inline also
ieee80211_rx_mgmt_assoc_resp() then I get 904 bytes.
johannes
prev parent reply other threads:[~2019-10-28 11:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 15:50 pull-request: mac80211-next 2019-07-31 Johannes Berg
2019-07-31 16:00 ` David Miller
2019-10-21 19:39 ` Arnd Bergmann
2019-10-28 9:51 ` Johannes Berg
2019-10-28 10:53 ` Arnd Bergmann
2019-10-28 10:59 ` Johannes Berg
2019-10-28 11:08 ` Johannes Berg
2019-10-28 11:38 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e6c13812faa01026b55d64c1af500eda048b759.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=john@phrozen.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox