From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BACB4C7EE22 for ; Wed, 10 May 2023 11:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236880AbjEJLZS (ORCPT ); Wed, 10 May 2023 07:25:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236322AbjEJLZR (ORCPT ); Wed, 10 May 2023 07:25:17 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BE9D7EC0 for ; Wed, 10 May 2023 04:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=w9MxrihC9RXYLubXGMYNsnytf0IQ9XTjJYddmYpxYys=; t=1683717883; x=1684927483; b=QCFOySlt5rs7QxpTgnBNjsJvcjqwMgqAyXKzz4I8CAkmI2N 6b+qCEioxOjm2n2Bb/yQm+2Sdyqy61N7q4W9hJFQu0PZ3yqHqBwxdEhKEYACR94KC/wAQ0h7qVvXD ln8Ssm6JG4qJn+AIMbogcdSsWyK2NPqvOO12sdFdKcylReiI6OCvgivdVy2WeCYRXnU3+r6CWxDHX bFrkFHykYl8B54IoIsJvgcH0U/nQpZOGC9hNsDVVxa7DAymFty6dfMYFuiKWkGsEBX+VdFUp10nkX 2cf94QVzFlvewyOCB2Ry3T9RXbyKvshanFJ3vZR25nBsUXomOVcdYqi+ngYCP9Ng==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.96) (envelope-from ) id 1pwhw1-005N3F-0N; Wed, 10 May 2023 13:24:41 +0200 Message-ID: <0e7023062f44d0ea68625c27cb13731d17857311.camel@sipsolutions.net> Subject: Re: [PATCH 10/27] wifi: mac80211: isolate driver from inactive links From: Johannes Berg To: Wen Gong , linux-wireless@vger.kernel.org Cc: ath11k@lists.infradead.org Date: Wed, 10 May 2023 13:24:40 +0200 In-Reply-To: <5e3ec5f8-1462-5de6-2b5a-4cf62f23deb7@quicinc.com> References: <20220902141259.377789-1-johannes@sipsolutions.net> <20220902161143.5ce3dad3be7c.I92e9f7a6c120cd4a3631baf486ad8b6aafcd796f@changeid> <5d82e564-86bf-c26b-077a-d0bc14e2d3c3@quicinc.com> <74f3eb848326607b15336c31a02bdd861ccafb47.camel@sipsolutions.net> <5e3ec5f8-1462-5de6-2b5a-4cf62f23deb7@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Wed, 2023-05-10 at 19:06 +0800, Wen Gong wrote: > On 4/11/2023 3:38 PM, Johannes Berg wrote: > > On Tue, 2023-04-04 at 11:28 +0800, Wen Gong wrote: > > > May I also add a field such as "u16 active_links_count" in struct > > > wiphy_iftype_ext_capab, > > > and add logic in function ieee80211_set_vif_links_bitmaps() for stati= on > > > like this ?: > > > if (active_links_count && hweight16(links) <=3D active_links_count) > > > =C2=A0=C2=A0=C2=A0 then sdata->vif.active_links =3D links; > > >=20 > > Also here, not sure it makes sense in cfg80211 level? > >=20 > > Though I'm not sure what the idea here is at all - you can refuse to > > link switch etc, what would you use this for? > >=20 > > Then again, we haven't really designed out all the link selection stuff= , > > do we want wpa_s to do it, driver to do it, etc.? Hence debugfs. So > > depending on what end up doing there, we will obviously need to > > advertise some level of link-concurrency to userspace. >=20 > So will you plan to do something to let wpa_s/userspace app=20 > active/deactive links? >=20 > Or you already have implemented that? >=20 No plans right now, and honestly not sure what the right thing even is. johannes