public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Zhen XIN <zhen.xin@nokia-sbell.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"martin.blumenstingl@googlemail.com"
	<martin.blumenstingl@googlemail.com>
Subject: RE: [PATCH -v2 2/2] wifi: rtw88: sdio: map mgmt frames to queue TX_DESC_QSEL_MGMT
Date: Tue, 15 Apr 2025 01:41:29 +0000	[thread overview]
Message-ID: <0ea484ea33794b1f9b99de46c94553ad@realtek.com> (raw)
In-Reply-To: <20250410154217.1849977-3-zhen.xin@nokia-sbell.com>

Zhen XIN <zhen.xin@nokia-sbell.com> wrote:
> Rtw88-sdio do not work in AP mode due to the lack of tx status report for
> management frames.
> 
> Map the management frames to queue TX_DESC_QSEL_MGMT, which enables the
> chip to generate TX reports for these frames

I will change the order of this patch to first one, because with patch 1/2
only, it will throw many messages that times out to wait for TX reports
from firmware. 

By the way, patch subject should contain "rtw-next" as hint for NIPA to
test build [1]. This patchset is simple so it also work to build with
wireless-next.

[1] https://patchwork.kernel.org/project/linux-wireless/patch/20250410154217.1849977-3-zhen.xin@nokia-sbell.com/

> 
> Tested-on: rtl8723ds
> 
> Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
> Signed-off-by: Zhen XIN <zhen.xin@nokia-sbell.com>
> ---
>  drivers/net/wireless/realtek/rtw88/sdio.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/sdio.c b/drivers/net/wireless/realtek/rtw88/sdio.c
> index ef51128a4b44..4311eb7cffef 100644
> --- a/drivers/net/wireless/realtek/rtw88/sdio.c
> +++ b/drivers/net/wireless/realtek/rtw88/sdio.c
> @@ -718,10 +718,7 @@ static u8 rtw_sdio_get_tx_qsel(struct rtw_dev *rtwdev, struct sk_buff *skb,
>         case RTW_TX_QUEUE_H2C:
>                 return TX_DESC_QSEL_H2C;
>         case RTW_TX_QUEUE_MGMT:
> -               if (rtw_chip_wcpu_11n(rtwdev))
> -                       return TX_DESC_QSEL_HIGH;
> -               else
> -                       return TX_DESC_QSEL_MGMT;
> +               return TX_DESC_QSEL_MGMT;
>         case RTW_TX_QUEUE_HI0:
>                 return TX_DESC_QSEL_HIGH;
>         default:
> --
> 2.25.1


  reply	other threads:[~2025-04-15  1:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-10 15:42 [PATCH -v2 0/2] wifi: rtw88: sdio: Enable tx status for management frames Zhen XIN
2025-04-10 15:42 ` [PATCH -v2 1/2] wifi: rtw88: sdio: call rtw_sdio_indicate_tx_status unconditionally Zhen XIN
2025-04-15 19:31   ` Martin Blumenstingl
2025-04-10 15:42 ` [PATCH -v2 2/2] wifi: rtw88: sdio: map mgmt frames to queue TX_DESC_QSEL_MGMT Zhen XIN
2025-04-15  1:41   ` Ping-Ke Shih [this message]
2025-04-15 19:31   ` Martin Blumenstingl
2025-04-16  0:32     ` Ping-Ke Shih
2025-04-16  5:31       ` Martin Blumenstingl
2025-04-17  5:43   ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0ea484ea33794b1f9b99de46c94553ad@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=zhen.xin@nokia-sbell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox