[PATCH -v2 0/2] wifi: rtw88: sdio: Enable tx status for management frames

[PATCH -v2 0/2] wifi: rtw88: sdio: Enable tx status for management frames

[Zhen XIN]

Rtw88-sdio do not work in AP mode due to the lack of tx status report for
management frames.

These patches put management frames into the right queue for tx status
report and ensure the correct handling of tx reports.

changes in v2: have the right queue as pointed out by Bitterblue Smith

Zhen XIN (2):
  wifi: rtw88: sdio: call rtw_sdio_indicate_tx_status unconditionally
  wifi: rtw88: sdio: map mgmt frames to queue TX_DESC_QSEL_MGMT

 drivers/net/wireless/realtek/rtw88/sdio.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

-- 
2.25.1

[PATCH -v2 1/2] wifi: rtw88: sdio: call rtw_sdio_indicate_tx_status unconditionally

[Zhen XIN]

Rtw88-sdio do not work in AP mode due to the lack of tx status report for
management frames.

Make the invocation of rtw_sdio_indicate_tx_status unconditional and cover
all packet queues

Tested-on: rtl8723ds

Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
Signed-off-by: Zhen XIN <zhen.xin@nokia-sbell.com>
---
 drivers/net/wireless/realtek/rtw88/sdio.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/sdio.c b/drivers/net/wireless/realtek/rtw88/sdio.c
index e024061bdbf7..ef51128a4b44 100644
--- a/drivers/net/wireless/realtek/rtw88/sdio.c
+++ b/drivers/net/wireless/realtek/rtw88/sdio.c
@@ -1227,10 +1227,7 @@ static void rtw_sdio_process_tx_queue(struct rtw_dev *rtwdev,
 		return;
 	}
 
-	if (queue <= RTW_TX_QUEUE_VO)
-		rtw_sdio_indicate_tx_status(rtwdev, skb);
-	else
-		dev_kfree_skb_any(skb);
+	rtw_sdio_indicate_tx_status(rtwdev, skb);
 }
 
 static void rtw_sdio_tx_handler(struct work_struct *work)
-- 
2.25.1

Re: [PATCH -v2 1/2] wifi: rtw88: sdio: call rtw_sdio_indicate_tx_status unconditionally

[Martin Blumenstingl]

On Thu, Apr 10, 2025 at 5:46 PM Zhen XIN <zhen.xin@nokia-sbell.com> wrote:
>
> Rtw88-sdio do not work in AP mode due to the lack of tx status report for
> management frames.
>
> Make the invocation of rtw_sdio_indicate_tx_status unconditional and cover
> all packet queues
>
> Tested-on: rtl8723ds
>
> Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
> Signed-off-by: Zhen XIN <zhen.xin@nokia-sbell.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

[PATCH -v2 2/2] wifi: rtw88: sdio: map mgmt frames to queue TX_DESC_QSEL_MGMT

[Zhen XIN]

Rtw88-sdio do not work in AP mode due to the lack of tx status report for
management frames.

Map the management frames to queue TX_DESC_QSEL_MGMT, which enables the
chip to generate TX reports for these frames

Tested-on: rtl8723ds

Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
Signed-off-by: Zhen XIN <zhen.xin@nokia-sbell.com>
---
 drivers/net/wireless/realtek/rtw88/sdio.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtw88/sdio.c b/drivers/net/wireless/realtek/rtw88/sdio.c
index ef51128a4b44..4311eb7cffef 100644
--- a/drivers/net/wireless/realtek/rtw88/sdio.c
+++ b/drivers/net/wireless/realtek/rtw88/sdio.c
@@ -718,10 +718,7 @@ static u8 rtw_sdio_get_tx_qsel(struct rtw_dev *rtwdev, struct sk_buff *skb,
 	case RTW_TX_QUEUE_H2C:
 		return TX_DESC_QSEL_H2C;
 	case RTW_TX_QUEUE_MGMT:
-		if (rtw_chip_wcpu_11n(rtwdev))
-			return TX_DESC_QSEL_HIGH;
-		else
-			return TX_DESC_QSEL_MGMT;
+		return TX_DESC_QSEL_MGMT;
 	case RTW_TX_QUEUE_HI0:
 		return TX_DESC_QSEL_HIGH;
 	default:
-- 
2.25.1

RE: [PATCH -v2 2/2] wifi: rtw88: sdio: map mgmt frames to queue TX_DESC_QSEL_MGMT

[Ping-Ke Shih]

Zhen XIN <zhen.xin@nokia-sbell.com> wrote:
> Rtw88-sdio do not work in AP mode due to the lack of tx status report for
> management frames.
> 
> Map the management frames to queue TX_DESC_QSEL_MGMT, which enables the
> chip to generate TX reports for these frames

I will change the order of this patch to first one, because with patch 1/2
only, it will throw many messages that times out to wait for TX reports
from firmware. 

By the way, patch subject should contain "rtw-next" as hint for NIPA to
test build [1]. This patchset is simple so it also work to build with
wireless-next.

[1] https://patchwork.kernel.org/project/linux-wireless/patch/20250410154217.1849977-3-zhen.xin@nokia-sbell.com/

> 
> Tested-on: rtl8723ds
> 
> Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
> Signed-off-by: Zhen XIN <zhen.xin@nokia-sbell.com>
> ---
>  drivers/net/wireless/realtek/rtw88/sdio.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtw88/sdio.c b/drivers/net/wireless/realtek/rtw88/sdio.c
> index ef51128a4b44..4311eb7cffef 100644
> --- a/drivers/net/wireless/realtek/rtw88/sdio.c
> +++ b/drivers/net/wireless/realtek/rtw88/sdio.c
> @@ -718,10 +718,7 @@ static u8 rtw_sdio_get_tx_qsel(struct rtw_dev *rtwdev, struct sk_buff *skb,
>         case RTW_TX_QUEUE_H2C:
>                 return TX_DESC_QSEL_H2C;
>         case RTW_TX_QUEUE_MGMT:
> -               if (rtw_chip_wcpu_11n(rtwdev))
> -                       return TX_DESC_QSEL_HIGH;
> -               else
> -                       return TX_DESC_QSEL_MGMT;
> +               return TX_DESC_QSEL_MGMT;
>         case RTW_TX_QUEUE_HI0:
>                 return TX_DESC_QSEL_HIGH;
>         default:
> --
> 2.25.1

Re: [PATCH -v2 2/2] wifi: rtw88: sdio: map mgmt frames to queue TX_DESC_QSEL_MGMT

[Martin Blumenstingl]

On Thu, Apr 10, 2025 at 5:46 PM Zhen XIN <zhen.xin@nokia-sbell.com> wrote:
>
> Rtw88-sdio do not work in AP mode due to the lack of tx status report for
Ping-Ke, in case you want to keep the spelling of rtw88 consistent:
can you update it while applying the patch (or do we need a v3)?
Same question for the other patch in this series.

> management frames.
>
> Map the management frames to queue TX_DESC_QSEL_MGMT, which enables the
> chip to generate TX reports for these frames
>
> Tested-on: rtl8723ds
>
> Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
> Signed-off-by: Zhen XIN <zhen.xin@nokia-sbell.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

RE: [PATCH -v2 2/2] wifi: rtw88: sdio: map mgmt frames to queue TX_DESC_QSEL_MGMT

[Ping-Ke Shih]

Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> 
> On Thu, Apr 10, 2025 at 5:46 PM Zhen XIN <zhen.xin@nokia-sbell.com> wrote:
> >
> > Rtw88-sdio do not work in AP mode due to the lack of tx status report for
> Ping-Ke, in case you want to keep the spelling of rtw88 consistent:
> can you update it while applying the patch (or do we need a v3)?
> Same question for the other patch in this series.

I can update commit messages while applying patches. But not sure what you
mentioned. Did you mean to change 'Rtw88-sdio' to 'rtw88-sdio'?

Re: [PATCH -v2 2/2] wifi: rtw88: sdio: map mgmt frames to queue TX_DESC_QSEL_MGMT

[Martin Blumenstingl]

On Wed, Apr 16, 2025 at 2:33 AM Ping-Ke Shih <pkshih@realtek.com> wrote:
>
> Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote:
> >
> > On Thu, Apr 10, 2025 at 5:46 PM Zhen XIN <zhen.xin@nokia-sbell.com> wrote:
> > >
> > > Rtw88-sdio do not work in AP mode due to the lack of tx status report for
> > Ping-Ke, in case you want to keep the spelling of rtw88 consistent:
> > can you update it while applying the patch (or do we need a v3)?
> > Same question for the other patch in this series.
>
> I can update commit messages while applying patches. But not sure what you
> mentioned. Did you mean to change 'Rtw88-sdio' to 'rtw88-sdio'?
Indeed, I meant changing Rtw88-sdio to rtw88-sdio

Thank you!

Re: [PATCH -v2 2/2] wifi: rtw88: sdio: map mgmt frames to queue TX_DESC_QSEL_MGMT

[Ping-Ke Shih]

Zhen XIN <zhen.xin@nokia-sbell.com> wrote:

> Rtw88-sdio do not work in AP mode due to the lack of tx status report for
> management frames.
> 
> Map the management frames to queue TX_DESC_QSEL_MGMT, which enables the
> chip to generate TX reports for these frames
> 
> Tested-on: rtl8723ds
> 
> Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
> Signed-off-by: Zhen XIN <zhen.xin@nokia-sbell.com>
> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

2 patch(es) applied to rtw-next branch of rtw.git, thanks.

b2effcdc2379 wifi: rtw88: sdio: map mgmt frames to queue TX_DESC_QSEL_MGMT
fc5f5a0ec463 wifi: rtw88: sdio: call rtw_sdio_indicate_tx_status unconditionally

---
https://github.com/pkshih/rtw.git