From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 567C1C433E0 for ; Fri, 22 May 2020 14:27:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 605CF22BEA for ; Fri, 22 May 2020 14:26:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=dd-wrt.com header.i=@dd-wrt.com header.b="BEym4zky" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730109AbgEVO05 (ORCPT ); Fri, 22 May 2020 10:26:57 -0400 Received: from mail.as201155.net ([185.84.6.188]:39865 "EHLO mail.as201155.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728947AbgEVO05 (ORCPT ); Fri, 22 May 2020 10:26:57 -0400 Received: from smtps.newmedia-net.de ([2a05:a1c0:0:de::167]:39799 helo=webmail.newmedia-net.de) by mail.as201155.net with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.82_1-5b7a7c0-XX) (envelope-from ) id 1jc8dR-0005lm-1r; Fri, 22 May 2020 16:26:53 +0200 X-CTCH-RefID: str=0001.0A782F23.5EC7E0CA.00C7,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dd-wrt.com; s=mikd; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject; bh=DbxJdF/fC0ie2bU2CmMmxB+eVF48vM2t3Frd0ebJjtw=; b=BEym4zkyhgz1ePHt/W3fF+0aJduX36+kSzQH3gTLeg9wMIXM7NlRVbd/+lyuP80uCwHuZ0RvFu5wBFZnsWy5WImI3xV7vZRCDh9OpKeF959xQ6iQiI1YcmSNoCRyhMYrtdqXAmnHtOVrXKq2gea90iqwayAprbQHwtr1NsQzutE=; Subject: Re: [PATCH v13] ath10k: add LED and GPIO controlling support for various chipsets To: Kalle Valo Cc: Sven Eckelmann , ath10k@lists.infradead.org, John Crispin , Ansuel Smith , openwrt-devel@lists.openwrt.org, Sebastian Gottschall , linux-wireless@vger.kernel.org References: <1523027875-5143-1-git-send-email-kvalo@codeaurora.org> <2468724.JaAZLprVu6@bentobox> <87wo549sas.fsf@codeaurora.org> From: Sebastian Gottschall Message-ID: <0fd74998-751c-6ae1-3584-fce145ec8f84@dd-wrt.com> Date: Fri, 22 May 2020 16:26:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:77.0) Gecko/20100101 Thunderbird/77.0 MIME-Version: 1.0 In-Reply-To: <87wo549sas.fsf@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Received: from [2a01:7700:8040:4000:c77:c0ea:fb54:feed] by webmail.newmedia-net.de with esmtpa (Exim 4.72) (envelope-from ) id 1jc8ZN-0004RV-DI; Fri, 22 May 2020 16:22:41 +0200 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Am 22.05.2020 um 12:29 schrieb Kalle Valo: > (please don't top post) > > Sebastian Gottschall writes: > >> this code is not in use in its original form for ipq4019. i have seen >> that his patch is also dropped from ath.git but is still in use by >> openwrt. could somone clarify the state here and why it was dropped? > I dropped the patch because of the bug report from openwrt. can you show me the bug report? and openwrt is still using it as out of tree patch which is confusing here. personally i'm using the patch on qca988x, qca9884 and also ipq40xx devices (40xx doesnt make any use of it of course) any chipset which doesnt make use of the gpio_pin definition is unable to make use of it. if there is no trigger set, its also not used (hopefully) but in any way i'm willig to fix any issue of there is a reproduceable issue. Sebastian >