From: "M. Vefa Bicakci" <m.v.b@runbox.com>
To: Matthias Beyer <mail@beyermatthias.de>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
joe@perches.com, Larry.Finger@lwfinger.net,
gregkh@linuxfoundation.org, Jes.Sorensen@redhat.com
Subject: Re: [PATCH v2 00/16] checkpatch clean-up of rtl8723au's rtw_security.c
Date: Sun, 15 Mar 2015 09:51 -0400 [thread overview]
Message-ID: <10669062.ZZNVxH5Tl9@lenny> (raw)
In-Reply-To: <20150315093142.GY24643@lucy.3gs>
On Sun, March 15, 2015 10:31:42 Matthias Beyer wrote:
> Hi,
>
> On 14-03-2015 20:10:25, M. Vefa Bicakci wrote:
> > These commits address a number of checkpatch.pl warnings and errors
> > in rtl8723au's rtw_security.c.
>
> Were these patches already applied? I cannot apply them on top of Greg
> KHs latest staging-next!
>
> I reviewed them and I want to add Reviewed-by: tags, but I would like
> to apply them on my kernel source copy first, just to re-check them!
Hello Matthias,
Thank you for reviewing the patches!
I have based and tested these commits on Stephen Rothwell's
linux-next.git/master branch. It is possible that I made a mistake
by doing this.
Nevertheless, I have just verified that these patches cleanly apply to the
current version of Greg Kroah-Hartman's staging.git/staging-next branch, [1]
as well as Stephen Rothwell's linux-next.git/master branch. [2]
In my local repo, here are my remotes:
$ git remote -v | grep -E "staging|next" | grep "(fetch)$"
next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git (fetch)
staging https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git (fetch)
I have just fetched both of these remotes.
$ git log -1 --oneline next/master
a68b04c773 Add linux-next specific files for 20150313
$ git log -1 --oneline staging/staging-next
7aa5d5097d Staging: rtl8192u: Use __packed instead of __attribute__((packed))
And here are my two local branches with my commits applied:
# Output slightly edited to reduce line length.
$ git branch -vv | grep -E "staging|next"
* linux-next c8ab62fb9c [next/master: ahead 16] staging: rtl8723au: Remove unneeded comments
staging-next 63f451681e [staging/staging-next: ahead 16] staging: rtl8723au: Remove unneeded comments
I hope this clarifies my set-up. Is there something I am doing incorrectly?
If there is anything I can assist with, please let me know.
Thank you,
Vefa
[1] https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/log/?h=staging-next
[2] https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/
next prev parent reply other threads:[~2015-03-15 13:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 0:10 [PATCH v2 00/16] checkpatch clean-up of rtl8723au's rtw_security.c M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 01/16] staging: rtl8723au: Reformat whitespace to increase readability M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 02/16] staging: rtl8723au: Fix "before/around/after" whitespace issues M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 03/16] staging: rtl8723au: else should follow close brace M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 04/16] staging: rtl8723au: Fix the indentation of two lines M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 05/16] staging: rtl8723au: Reorganize a few functions to remove indentation M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 06/16] staging: rtl8723au: Do not initialize a static to 0 M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 07/16] staging: rtl8723au: else is not generally useful after a return M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 08/16] staging: rtl8723au: Remove unneeded curly braces M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 09/16] staging: rtl8723au: trailing statements should be on next line M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 10/16] staging: rtl8723au: that open brace should be on the previous line M. Vefa Bicakci
2015-03-16 16:36 ` Jes Sorensen
2015-03-15 0:10 ` [PATCH v2 11/16] staging: rtl8723au: No spaces at the start of a line M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 12/16] staging: rtl8723au: Adjust whitespace in and around comments M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 13/16] staging: rtl8723au: suspect code indent for conditional statements M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 14/16] staging: rtl8723au: Rework two byte array comparisons M. Vefa Bicakci
2015-03-15 0:10 ` [PATCH v2 15/16] staging: rtl8723au: Correct a typo in a trace log line M. Vefa Bicakci
2015-03-16 16:38 ` Jes Sorensen
2015-03-15 0:10 ` [PATCH v2 16/16] staging: rtl8723au: Remove unneeded comments M. Vefa Bicakci
2015-03-15 9:31 ` [PATCH v2 00/16] checkpatch clean-up of rtl8723au's rtw_security.c Matthias Beyer
2015-03-15 13:51 ` M. Vefa Bicakci [this message]
2015-03-16 16:01 ` Jes Sorensen
2015-03-16 16:55 ` Joe Perches
2015-03-16 17:07 ` Greg KH
2015-03-16 17:11 ` Joe Perches
2015-03-19 4:34 ` M. Vefa Bicakci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10669062.ZZNVxH5Tl9@lenny \
--to=m.v.b@runbox.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mail@beyermatthias.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).