Re: [PATCH wireless-next 03/18] wifi: nl80211: avoid rtnl for commands that don't want it

[Johannes Berg <johannes@sipsolutions.net>]

On Mon, 2026-10-05 at 12:18 +0800, kernel test robot wrote:
> 
> > > net/wireless/nl80211.c:244:7: warning: variable 'wdev' is uninitialized when used here [-Wuninitialized]
>      244 |             (wdev->netdev && !net_eq(dev_net(wdev->netdev), netns))) {
>          |              ^~~~

Yes ... noticed that too, just slightly too late.

>    net/wireless/nl80211.c:238:27: note: initialize the variable 'wdev' to silence this warning
>      238 |         struct wireless_dev *wdev;
>          |                                  ^
>          |                                   = NULL

That'd be pointless.

>  > 244		    (wdev->netdev && !net_eq(dev_net(wdev->netdev), netns))) {

that line

>    245			wiphy_unlock(&rdev->wiphy);
>    246			put_device(&rdev->wiphy.dev);
>    247			return ERR_PTR(-ENODEV);
>    248		}
>    249	
>    250		/*
>    251		 * unregistration blocks on wiphy mutex,
>    252		 * so we don't need this now
>    253		 */
>    254		put_device(&rdev->wiphy.dev);
>    255	
>    256		if (!wdev_id)
>    257			return NULL;
>    258	
>    259		list_for_each_entry(wdev, &rdev->wiphy.wdev_list, list) {
>    260			if (wdev->identifier == wdev_id)
>    261				return wdev;

needs to move here.

johannes