Re: [PATCH 1/4] create cfg80211

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

On Fri, 2007-02-09 at 17:27 +0100, johannes@sipsolutions.net wrote:

This

> +void wiphy_free(struct wiphy *wiphy)
> +{
> +	if (wiphy->wiphy_index != -1)
> +		wiphy_sysfs_del(wiphy);
> +	else
> +		cfg80211_drv_free(wiphy_to_drv(wiphy));
> +}

and this

> +static void wiphy_class_dev_release(struct class_device *cdev)
> +{
> +	struct cfg80211_registered_driver *drv = cdev_to_drv(cdev);
> +
> +	cfg80211_drv_free(drv);
> +}

needs to be changed. wiphy_free() should wait for
wiphy_class_dev_release (to make sure sysfs is gone) before freeing the
structure (if it has ever been added to sysfs).

I'll respin both patchsets tomorrow. Until then, should you want to test
it and not just review the code, please just comment out the
cfg80211_drv_free(drv) in wiphy_class_dev_release, that'll give you a
memory leak though, but I have to leave and can't write the code
handling it with a completion etc. in under a minute ;)

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]