From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] prism54: correct assignment of DOT1XENABLE in WE-19 codepaths
Date: Tue, 13 Feb 2007 14:18:26 -0500 [thread overview]
Message-ID: <1171394306.5329.24.camel@localhost.localdomain> (raw)
In-Reply-To: <1171393331.10344.106.camel@johannes.berg>
On Tue, 2007-02-13 at 20:02 +0100, Johannes Berg wrote:
> On Tue, 2007-02-13 at 14:00 -0500, Dan Williams wrote:
> > Correct assignment of DOT1XENABLE in WE-19 codepaths.
> > RX_UNENCRYPTED_EAPOL = 1 really means setting DOT1XENABLE _off_, and
> > vice versa. The original WE-19 patch erroneously reversed that. This
> > patch fixes association with unencrypted and WEP networks when using
> > wpa_supplicant.
> >
> > It also adds two missing break statements that, left out, could result
> > in incorrect card configuration.
> >
> > Please commit to both development and stable branches.
^^^^^
Right; applicable to anything after _and_ including 2.6.19, which is
when I think the WE-19 patch landed.
Dan
>
> I guess it could also be applicable for stable?
>
> johannes
next prev parent reply other threads:[~2007-02-13 19:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 19:00 [PATCH] prism54: correct assignment of DOT1XENABLE in WE-19 codepaths Dan Williams
2007-02-13 19:02 ` Johannes Berg
2007-02-13 19:18 ` Dan Williams [this message]
2007-02-13 19:20 ` Johannes Berg
2007-02-13 20:36 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1171394306.5329.24.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox