From: Pavel Roskin <proski@gnu.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rt2x00: Fix max_rssi values signedness bug
Date: Tue, 20 Feb 2007 20:18:49 -0500 [thread overview]
Message-ID: <1172020729.6042.2.camel@dv> (raw)
In-Reply-To: <200702202102.14354.mb@bu3sch.de>
On Tue, 2007-02-20 at 21:02 +0100, Michael Buesch wrote:
> char is not signed on all architectures.
> This fixes a compiletime warning and bug on PPC.
Then we have a bigger problem. Please see include/net/d80211.h:
> /* Maximum values for various statistics.
> * Leave at 0 to indicate no support. Use negative numbers for dBm. */
> char max_rssi;
> char max_signal;
> char max_noise;
So, there will be no dBm on PowerPC. I think those fields should be
"signed char".
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2007-02-21 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 20:02 [PATCH] rt2x00: Fix max_rssi values signedness bug Michael Buesch
2007-02-21 1:18 ` Pavel Roskin [this message]
2007-02-21 1:25 ` Michael Wu
2007-02-21 1:47 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172020729.6042.2.camel@dv \
--to=proski@gnu.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).