From: Johannes Berg <johannes@sipsolutions.net>
To: Jiri Benc <jbenc@suse.cz>
Cc: Michael Wu <flamingice@sourmilk.net>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] d80211: Fix ieee80211_ptr check
Date: Thu, 22 Feb 2007 15:06:18 +0100 [thread overview]
Message-ID: <1172153178.5080.32.camel@johannes.berg> (raw)
In-Reply-To: <20070221190123.66606886@griffin.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 845 bytes --]
On Wed, 2007-02-21 at 19:01 +0100, Jiri Benc wrote:
> On Tue, 20 Feb 2007 18:13:54 -0500, Michael Wu wrote:
> > dev->ieee80211_ptr can no longer be directly compared to check if a virtual
> > interface belongs to a master device.
>
> Hm, apparently the regexp I tried when resolving conflicts with John's
> tree wasn't good enough to catch this :-(
No, that's an error I made.
> Let's hope there are no more such things left.
I doubt it. I should have remembered this special case but forgot about
it. The thing is that in earlier wiphy versions I had ieee80211_ptr
point to the wiphy directly so I *intentionally* kept the comparison
like that when reviewing all uses of ieee80211_ptr. When I realised that
we need per-netdev wireless state I put that behind ieee80211_ptr and
then forgot to update this spot.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
prev parent reply other threads:[~2007-02-22 14:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 23:13 [PATCH] d80211: Fix ieee80211_ptr check Michael Wu
2007-02-21 18:01 ` Jiri Benc
2007-02-22 14:06 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1172153178.5080.32.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox