linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dcbw@redhat.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Jouni Malinen <jkm@devicescape.com>,
	wireless <linux-wireless@vger.kernel.org>
Subject: Re: cfg/nl80211 primitives
Date: Thu, 08 Mar 2007 14:36:39 -0500	[thread overview]
Message-ID: <1173382599.3020.34.camel@localhost.localdomain> (raw)
In-Reply-To: <1173380977.3248.55.camel@johannes.berg>

On Thu, 2007-03-08 at 20:09 +0100, Johannes Berg wrote:
> On Wed, 2007-03-07 at 16:49 -0800, Jouni Malinen wrote:
> 
> > And where would
> >    (5) change some parameters within this association without triggering
> >        new authentication/association
> > fit in?
> 
> For that case it's just a new configure command I suppose.
> 
> > > However, I don't see why we shouldn't go to a model where we give the
> > > kernel all information it needs to do an operation when we want it to do
> > > it, like the procedure
> > >  (1) tell the kernel to do X
> > >    - using parameter A=B
> > >    - using parameter C=D
> > >    - ...
> > >  (2) tell the kernel to do Y
> > 
> > Would this be all parameters as in _no_ other parameters could be set
> > before or after the command? As an example, how would one set
> > fragmentation threshold and then change that value after having
> > associated?
> 
> Actually, things like the fragmentation threshold or say rx sensitivity
> (where it can be set) don't really influence the association so for
> those I'd think they are out of scope for the MLME SAP primitives.
> 
> > MLME SAP primitives may be okay for many cases, but we cannot limit
> > ourselves to just the parameters defined there. Number of parameters do
> > not go through MLME SAP interface and some of the options may require
> > getting used to (e.g., power management options would use their own
> > primitive, not MLME-ASSOCIATE, etc.).
> 
> Right.
> 
> > MLME SAP interface is between MLME and SME, but when we have some parts
> > of MLME in user space and some in kernel, things can get bit confusing
> > since the interface between MLME and SME is not the same as interface
> > between kernel and user space.
> 
> True.
> 
> I think what I should have said when I wrote this email is that I
> dislike having this "transaction layer" in the kernel where you set a
> bunch of settings and then "commit" them by saying "please associate now
> with whatever settings I told you to use".

So when wpa_supplicant or whatever has to do rekeying, or if I want to
change some parameter but not completely re-associate, how does that
work?

> What I'd like to see instead is that you give the MLME (whether it's in
> the kernel or in userspace[1]) all the parameters it needs to do one
> action when telling it to do that action.

I'd basically expected that this was the model we'd be using anyway.  A
user tool wouldn't have to:

set ssid
set key
set authmode
associate

but instead bundle all those up into one message to netlink with the
"associate" command or something.  I wasn't expecting each setting to be
broken down into a separate message and then have a final "commit"
command like with WEXT right now.  That sucks and makes command ordering
ambiguous.

I'd much rather conceptually have the following (in python-esque), which
is what I thought it would be more like...

err = associate(ssid="foo", key=0x435223, auth="shared")
<rekey>
err = set(key=0x235326563)

Dan

> I'm not saying that we should limit ourselves to the parameters outlined
> in the MLME SAP interface nor that we should really follow it closely.
> 
> johannes
> 
> [1] since we said we'd want the userspace mlme to be controlled by
> nl80211 through the kernel


  reply	other threads:[~2007-03-08 19:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-06 22:20 cfg/nl80211 primitives Johannes Berg
2007-03-08  0:49 ` Jouni Malinen
2007-03-08 19:09   ` Johannes Berg
2007-03-08 19:36     ` Dan Williams [this message]
2007-03-08 19:36       ` Johannes Berg
2007-03-16 15:39         ` Jiri Benc
2007-03-16 17:05           ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1173382599.3020.34.camel@localhost.localdomain \
    --to=dcbw@redhat.com \
    --cc=jkm@devicescape.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).