From: Johannes Berg <johannes@sipsolutions.net>
To: Jiri Benc <jbenc@suse.cz>
Cc: Daniel Drake <dsd@gentoo.org>,
linville@tuxdriver.com, linux-wireless@vger.kernel.org,
kune@deine-taler.de
Subject: Re: [PATCH] zd1211rw-mac80211: Fix for monitor mode bug
Date: Mon, 26 Mar 2007 11:59:58 +0200 [thread overview]
Message-ID: <1174903199.1536.4.camel@johannes.berg> (raw)
In-Reply-To: <20070326115412.2786c8f4@griffin.suse.cz>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
On Mon, 2007-03-26 at 11:54 +0200, Jiri Benc wrote:
> But this feature of zd1211 looks interesting. Johannes, shouldn't we
> add a parameter to cfg80211 allowing such packets to be received by
> monitor iterfaces?
Dunno. bcm43xx has this feature too, it even allows you to bypass the
second CRC check in the PLCP header. Picks up your microwave with
that ;)
Maybe take this into account for the driver API when implementing
IFF_PROMISC as we talked about?
> Daniel, does zd1211 send information about failed CRC check with the
> packet? Or do we need to recheck CRC in the stack if the feature
> mentioned above is implemented and there are both regular and monitor
> interface operating?
bcm43xx doesn't tell you when the CRC failed, nor does it tell you when
the PLCP CRC failed (if you want to see those frames). Hence, we'd have
to recheck the CRC(s).
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-03-26 10:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-25 23:18 [PATCH] zd1211rw-mac80211: Fix for monitor mode bug Daniel Drake
2007-03-26 9:54 ` Jiri Benc
2007-03-26 9:59 ` Johannes Berg [this message]
2007-03-26 10:14 ` Andy Green
2007-03-26 11:28 ` Michael Buesch
2007-03-26 11:31 ` Johannes Berg
2007-03-26 20:39 ` Michael Buesch
2007-03-28 9:19 ` Johannes Berg
2007-03-28 9:55 ` Michael Buesch
2007-03-28 10:18 ` PLCP header information (was: Re: [PATCH] zd1211rw-mac80211: Fix for monitor mode bug) Johannes Berg
2007-03-26 10:28 ` [PATCH] zd1211rw-mac80211: Fix for monitor mode bug Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1174903199.1536.4.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=dsd@gentoo.org \
--cc=jbenc@suse.cz \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).