linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Tomas Winkler <tomasw@gmail.com>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
	mohamed <mabbas@linux.intel.com>,
	linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [patch 2/5] Add basic support for IEEE 802.11n discovery and  association
Date: Fri, 30 Mar 2007 12:38:32 +0200	[thread overview]
Message-ID: <1175251112.19085.4.camel@johannes.berg> (raw)
In-Reply-To: <1ba2fa240703291648h6b0d10bdje2ea54f3c1754f5b@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

On Fri, 2007-03-30 at 01:48 +0200, Tomas Winkler wrote:

> Can someone  explain to me what is rational to choose between  making
> information element (IE) a struct  or 'rolling it into the code' . I'm
> finding it much more readable to use struct and when it  changes for
> example because 11n draft changes. And the change is reflected in
> compilation time. 

I wasn't talking about making it a struct or not, I was merely saying
that there isn't much point in a three-line function that does
essentially nothing related to the actual task.

johannes


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

  parent reply	other threads:[~2007-03-30 10:39 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-26 11:38 [patch 2/5] Add basic support for IEEE 802.11n discovery and association mohamed
2007-03-26 23:52 ` Randy Dunlap
2007-04-04 10:37   ` mabbas
2007-03-27 17:05 ` Luis R. Rodriguez
2007-03-27 17:11   ` Luis R. Rodriguez
2007-03-27 17:29     ` Luis R. Rodriguez
2007-03-29  6:04       ` mohamed
2007-03-28 19:11         ` Luis R. Rodriguez
2007-03-29  7:21           ` mohamed
2007-03-28  9:14 ` Johannes Berg
2007-03-29  5:56   ` mohamed
2007-03-28 20:03 ` Johannes Berg
2007-03-29 19:46   ` Luis R. Rodriguez
     [not found]     ` <1ba2fa240703291648h6b0d10bdje2ea54f3c1754f5b@mail.gmail.com>
2007-03-30 10:38       ` Johannes Berg [this message]
     [not found]         ` <1ba2fa240703300418r781931cdp50430dcb02259f1@mail.gmail.com>
2007-03-30 12:11           ` Johannes Berg
2007-03-31 15:37 ` Michael Wu
2007-04-11 19:40   ` John W. Linville
2007-04-11 20:04     ` mabbas
2007-04-11 20:29       ` Michael Wu
2007-04-11 22:03         ` Tomas Winkler
2007-04-11 22:50           ` Simon Barber
2007-04-11 23:05             ` Tomas Winkler
2007-04-11 23:25               ` Andy Green
2007-04-12  8:56                 ` Johannes Berg
2007-04-12  9:01                   ` Andy Green
2007-04-12  9:06                     ` Johannes Berg
2007-04-12  0:20               ` Simon Barber
2007-04-12  1:13                 ` Tomas Winkler
2007-04-11 22:23         ` mabbas
2007-04-11 22:56           ` Michael Wu
2007-04-12 18:11             ` mabbas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175251112.19085.4.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mabbas@linux.intel.com \
    --cc=mcgrof@gmail.com \
    --cc=tomasw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).