linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Theo de Raadt <deraadt@cvs.openbsd.org>
Cc: Michael Buesch <mb@bu3sch.de>, Jeff Garzik <jeff@garzik.org>,
	Marcus Glocker <mglocker@openbsd.org>,
	Jon Simola <jsimola@gmail.com>, Theo de Raadt <deraadt@theos.com>,
	Stefano Brivio <stefano.brivio@polimi.it>,
	Martin Langer <martin-langer@gmx.de>,
	Danny van Dyk <kugelfang@gentoo.org>,
	Andreas Jaggi <andreas.jaggi@waterwave.ch>,
	Larry Finger <larry.finger@lwfinger.net>,
	Quaker.Fang@sun.com, Joseph Jezak <josejx@gentoo.org>,
	John Linville <linville@tuxdriver.com>, Greg kh <greg@kroah.com>,
	bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org,
	license-violation@gpl-violations.org
Subject: Re: OpenBSD bcw: Possible GPL license violation issues
Date: Thu, 05 Apr 2007 23:49:59 +0200	[thread overview]
Message-ID: <1175809799.3489.31.camel@johannes.berg> (raw)
In-Reply-To: <200704052133.l35LXmZA032186@cvs.openbsd.org>

[-- Attachment #1: Type: text/plain, Size: 1743 bytes --]

On Thu, 2007-04-05 at 15:33 -0600, Theo de Raadt wrote:

> Those were just 'EXAMPLES'?  So you had no evidence?  Why would you
> show examples of white space and variable naming when you had real
> evidence?  Or did you think that the examples would be evidence?

Of course you're putting things out of context and order again, which
we've all seen enough in this thread; but let me set this straight:

When we discovered that the driver looked similar, we first looked for
instances of code that were apparently copied (as Marcus claims "a lot
of lines in bcw are written in a way with a too close eye to your
code.") At that point we still assumed they actually were just rewritten
versions of the same functions.

However, discovering, for example, an implementation (!) of an abstract
state machine (yes, don't explain to me again how you cannot copyright a
state machine) that is exactly identical to the implementation in
bcm43xx when the description in the specs basically looks like an
octagon, we decided to look further, and discovered things like:

http://www.openbsd.org/cgi-bin/cvsweb/src/sys/dev/ic/Attic/bcw.c.diff?r1=1.77&r2=1.78

where original code that Jon Simola wrote from the specs (!) is ripped
out and replaced by something that comes straight from bcm43xx.

And at that point, still wondering if it was just written similarly,
Stefano started comparing it on a much lower level and discovered that
there's just no way that the seemingly similar code could have been
rewritten and not copied since that would imply that there's at least
some difference except for a quick s/bcm43xx/bcw/g and re-editing of
some strings.

So that's how we got to whitespace. For the record.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

  reply	other threads:[~2007-04-05 21:50 UTC|newest]

Thread overview: 104+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-04 20:08 OpenBSD bcw: Possible GPL license violation issues Michael Buesch
2007-04-04 21:39 ` Theo de Raadt
2007-04-05  0:18   ` Stefano Brivio
2007-04-05  0:29     ` Theo de Raadt
2007-04-05  0:52       ` Joseph Jezak
2007-04-05  1:56         ` Theo de Raadt
2007-04-05  2:07           ` Joseph Jezak
2007-04-05  2:10             ` Theo de Raadt
2007-04-05 17:03               ` Michael Buesch
2007-04-05 17:05                 ` Theo de Raadt
2007-04-05 17:40                   ` Michael Buesch
2007-04-05 17:44                     ` Theo de Raadt
2007-04-05 18:00                     ` Theo de Raadt
2007-04-05 18:30                       ` Michael Buesch
2007-04-05 18:32                         ` Theo de Raadt
2007-04-05 18:39                           ` Paul Marks
2007-04-05 18:41                             ` Theo de Raadt
2007-04-05 18:47                           ` Michael Buesch
2007-04-05 18:48                             ` Theo de Raadt
2007-04-05 19:09                               ` Michael Buesch
2007-04-05 19:13                                 ` Theo de Raadt
2007-04-05 19:20                                   ` Jeff Garzik
2007-04-05 19:13                                 ` Theo de Raadt
2007-04-05 19:25                                   ` Michael Buesch
2007-04-05 19:29                                     ` Theo de Raadt
2007-04-05 19:45                                       ` Michael Buesch
2007-04-05 19:46                                         ` Theo de Raadt
2007-04-05 19:35                                     ` Stefano Brivio
2007-04-05 19:31                               ` Pavel Roskin
2007-04-05 19:37                                 ` Theo de Raadt
2007-04-05 19:57                                   ` Luis R. Rodriguez
2007-04-05 20:10                                     ` Theo de Raadt
2007-04-05 21:19                                       ` Stefano Brivio
2007-04-05 21:25                                         ` Theo de Raadt
2007-04-05 21:36                                           ` Johannes Berg
2007-04-05 21:39                                             ` Theo de Raadt
2007-04-05 22:46                                               ` Johannes Berg
2007-04-05 23:23                                                 ` Theo de Raadt
2007-04-05 23:34                                                   ` Johannes Berg
2007-04-05 23:34                                                     ` Theo de Raadt
2007-04-05 23:46                                                       ` Michael Buesch
2007-04-05 23:51                                                         ` Theo de Raadt
2007-04-06  0:00                                                           ` Stefano Brivio
2007-04-06  0:02                                                           ` Michael Buesch
2007-04-05 22:59                                               ` Ivo van Doorn
2007-04-05 23:28                                                 ` Theo de Raadt
2007-04-06  9:04                                                   ` Ivo van Doorn
2007-04-06  9:14                                                     ` Michael Buesch
2007-04-06 10:53                                                       ` Ivo van Doorn
2007-04-05 22:03                                           ` Stefano Brivio
2007-04-05 21:23                                     ` Theo de Raadt
2007-04-06  0:19                                 ` Theo de Raadt
2007-04-06  5:12                                   ` Pavel Roskin
2007-04-05  0:59       ` Stefano Brivio
2007-04-05  1:12         ` Theo de Raadt
2007-04-05  1:40           ` Stefano Brivio
2007-04-05 16:41       ` Michael Buesch
2007-04-05 16:42         ` Theo de Raadt
2007-04-05 16:57   ` Michael Buesch
2007-04-05 17:00     ` Theo de Raadt
2007-04-05 17:35       ` Michael Buesch
2007-04-05 17:40         ` Theo de Raadt
2007-04-05 18:54       ` Jeff Garzik
2007-04-05 20:21         ` Theo de Raadt
2007-04-05 20:26           ` Jeff Garzik
2007-04-05 20:28             ` Theo de Raadt
2007-04-05 20:39               ` Jeff Garzik
2007-04-05 20:56                 ` Theo de Raadt
2007-04-05 21:21                   ` David Miller
2007-04-05 23:21                     ` Theo de Raadt
2007-04-05 23:23                     ` Theo de Raadt
2007-04-05 21:26                   ` Michael Buesch
2007-04-05 21:33                     ` Theo de Raadt
2007-04-05 21:49                       ` Johannes Berg [this message]
2007-04-05 21:52                       ` Michael Buesch
2007-04-05 21:53                   ` Stefano Brivio
2007-04-08 11:21   ` Pieter Hulshoff
2007-04-04 22:22 ` Theo de Raadt
2007-04-04 22:35   ` Johannes Berg
2007-04-05 16:59   ` Michael Buesch
2007-04-05  5:41 ` Marcus Glocker
2007-04-05 16:34   ` Marcus Glocker
2007-04-05 16:36     ` Theo de Raadt
2007-04-05 17:31     ` Michael Buesch
2007-04-05 17:36       ` Theo de Raadt
2007-04-05 16:47   ` Michael Buesch
2007-04-05 16:48     ` Theo de Raadt
2007-04-05 17:14       ` Michael Buesch
2007-04-05 17:25         ` Theo de Raadt
2007-04-05 17:53           ` Michael Buesch
2007-04-05 17:54             ` Theo de Raadt
2007-04-05 18:28             ` Theo de Raadt
2007-04-05 18:40               ` Michael Buesch
2007-04-05 18:42                 ` Theo de Raadt
2007-04-05 19:08                   ` Stefano Brivio
2007-04-05 17:29         ` Theo de Raadt
2007-04-05 18:10         ` Theo de Raadt
2007-04-07  8:12   ` Joerg Mayer
2007-04-08  0:04 ` Pieter Hulshoff
2007-04-08 13:27 ` Reyk Floeter
2007-04-08 13:50   ` Michael Buesch
2007-04-08 18:29     ` Reyk Floeter
2007-04-08 17:06   ` Pavel Roskin
  -- strict thread matches above, loose matches on Subject: below --
2007-04-12  9:28 nihil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1175809799.3489.31.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=Quaker.Fang@sun.com \
    --cc=andreas.jaggi@waterwave.ch \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=deraadt@cvs.openbsd.org \
    --cc=deraadt@theos.com \
    --cc=greg@kroah.com \
    --cc=jeff@garzik.org \
    --cc=josejx@gentoo.org \
    --cc=jsimola@gmail.com \
    --cc=kugelfang@gentoo.org \
    --cc=larry.finger@lwfinger.net \
    --cc=license-violation@gpl-violations.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=martin-langer@gmx.de \
    --cc=mb@bu3sch.de \
    --cc=mglocker@openbsd.org \
    --cc=stefano.brivio@polimi.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).