From: David Woodhouse <dwmw2@infradead.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Bcm43xx-dev@lists.berlios.de, linux-wireless@vger.kernel.org,
Stefano Brivio <stefano.brivio@polimi.it>,
Michael Buesch <mb@bu3sch.de>,
Larry Finger <larry.finger@lwfinger.net>
Subject: Re: [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs
Date: Mon, 16 Apr 2007 01:53:53 +0100 [thread overview]
Message-ID: <1176684833.3304.9.camel@pmac.infradead.org> (raw)
In-Reply-To: <1176681998.7929.81.camel@pmac.infradead.org>
On Mon, 2007-04-16 at 01:06 +0100, David Woodhouse wrote:
> On Fri, 2007-04-13 at 17:17 +0200, Johannes Berg wrote:
> > With phy rev == 1, the gmode bit is assumed unset when initialising a
> > G PHY. Maybe that is the crucial difference. David will send me some
> > backtraces of this problem, once he does I'll look at it again.
>
> http://david.woodhou.se/bcm43xx-mac80211.dmesg-3.txt
>
> The module itself is at http://david.woodhou.se/bcm43xx-mac80211.ko so
> you can find line numbers where they're not immediately obvious.
That was without Larry's latest patch applied. If I apply Larry's patch,
we get fewer machine checks...
http://david.woodhou.se/bcm43xx-mac80211-lf.dmesg.txt
http://david.woodhou.se/bcm43xx-mac80211-lf.ko
Strange, I thought that when I'd tested Larry's patch I was left with
_no_ machine checks. Perhaps at that point I still had a printk on every
PHY read or write and the machine checks were lost in the noise.
--
dwmw2
prev parent reply other threads:[~2007-04-16 0:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 16:08 [PATCH] bcm43xx-mac80211: Fix machine checks on PPC with rev 1 PHYs Larry Finger
2007-04-11 17:22 ` Michael Buesch
2007-04-13 0:09 ` John W. Linville
2007-04-13 0:57 ` Pavel Roskin
2007-04-13 1:22 ` Larry Finger
2007-04-16 1:04 ` David Woodhouse
2007-04-17 17:08 ` Larry Finger
2007-04-13 9:36 ` Stefano Brivio
2007-04-13 15:06 ` Larry Finger
2007-04-13 15:17 ` Johannes Berg
2007-04-16 0:06 ` David Woodhouse
2007-04-16 0:53 ` David Woodhouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176684833.3304.9.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=johannes@sipsolutions.net \
--cc=larry.finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=stefano.brivio@polimi.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).