Re: [PATCH] ieee80211-crypt: Make some TKIP and CCMP error logging conditional on IEEE80211_DEBUG_DROP

[Dan Williams <dcbw@redhat.com>]

On Tue, 2007-04-17 at 09:12 -0400, John W. Linville wrote:
> On Mon, Apr 16, 2007 at 07:24:14PM -0500, Larry Finger wrote:
> > Michael Buesch wrote:
> > > On Monday 16 April 2007 20:50, Larry Finger wrote:
> 
> > >> @@ -229,6 +229,7 @@ void free_ieee80211(struct net_device *d
> > >>
> > >>   static int debug = 0;
> > >>   u32 ieee80211_debug_level = 0;
> > >> +EXPORT_SYMBOL_GPL(ieee80211_debug_level);
> > > 
> > > We don't use the _GPL suffix in mac80211.
> > 
> > Upon inspection, neither does most of ieee80211. It is now changed.
> 
> You are strongly encouraged to use the _GPL version for new symbol
> exports, especially those which are fundamentally internal to
> in-kernel subsystems and/or have no reasonable usage by drivers.
> FWIW, this symbol would seem to fulfill both of those criteria.
> 
> If you do not object, I would prefer the _GPL version of the patch.

What's the rationale for mac80211 _not_ using _GPL exports? I thought
most new exports were pretty much required to be _GPL (otherwise
somebody would NAK it) unless it was really, really necessary that they
weren't.

Dan