Re: [PATCH] mac80211: add sta item when changing WDS address

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 966 bytes --]

On Tue, 2007-03-27 at 18:01 +0200, Johannes Berg wrote:
> This patch adds a sta item for the new address when you change a WDS
> link's address. If the sta item cannot be created return an error.

Anything wrong with this patch? :)

> --- wireless-dev.orig/net/mac80211/ieee80211.c	2007-03-27 16:33:29.523155480 +0200
> +++ wireless-dev/net/mac80211/ieee80211.c	2007-03-27 16:33:47.163155480 +0200
> @@ -4418,6 +4418,15 @@ int ieee80211_if_update_wds(struct net_d
>  	struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev);
>  	struct sta_info *sta;
>  
> +	if (compare_ether_addr(remote_addr, sdata->u.wds.remote_addr) == 0)
> +		return 0;
> +
> +	/* Create STA entry for the new peer */
> +	sta = sta_info_add(local, dev, remote_addr, GFP_KERNEL);
> +	if (!sta)
> +		return -ENOMEM;
> +	sta_info_put(sta);
> +
>  	/* Remove STA entry for the old peer */
>  	sta = sta_info_get(local, sdata->u.wds.remote_addr);
>  	if (sta) {


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]