From: Johannes Berg <johannes@sipsolutions.net>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Michael Wu <flamingice@sourmilk.net>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] Add 93cx6 eeprom library
Date: Sun, 13 May 2007 10:22:54 +0200 [thread overview]
Message-ID: <1179044574.2647.26.camel@johannes.berg> (raw)
In-Reply-To: <200705131013.15985.IvDoorn@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 675 bytes --]
On Sun, 2007-05-13 at 10:13 +0200, Ivo van Doorn wrote:
> > > +}
> > > +EXPORT_SYMBOL_GPL(eeprom_93cx6_multiread);
> > > +
> >
> > It's pedantic, but I hate empty lines at the end of files...
>
> GCC usually complains when a file does not have a empty line
> at the end of the file.
Nah, it only complains when the file ends with a character other than
'\n', i.e. the last line has contents. This would be represented as
+EXPORT_SYMBOL_GPL(eeprom_93cx6_multiread);
+\ No newline at end of file
in a unified diff, where that "\ No newline at end of file" text is not
part of the hunk (that is, the hunk linecount doesn't include it)
:)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-05-13 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-11 19:59 [PATCH 1/2] Add 93cx6 eeprom library Michael Wu
2007-05-11 20:07 ` Ivo van Doorn
2007-05-12 19:17 ` John W. Linville
2007-05-13 1:29 ` Michael Wu
2007-05-13 8:13 ` Ivo van Doorn
2007-05-13 8:22 ` Johannes Berg [this message]
2007-05-13 18:50 ` Jeff Garzik
2007-05-14 17:45 ` John W. Linville
-- strict thread matches above, loose matches on Subject: below --
2007-05-07 7:46 Michael Wu
2007-05-07 7:53 ` Ivo van Doorn
2007-05-07 14:27 ` Ben Dooks
2007-05-07 15:34 ` John W. Linville
2007-05-07 15:40 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1179044574.2647.26.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).