From: Zhu Yi <yi.zhu@intel.com>
To: Jiri Benc <jbenc@suse.cz>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
Michael Wu <flamingice@sourmilk.net>
Subject: Re: [PATCH 1/3] mac80211: add IEEE802.11e/WMM structures
Date: Fri, 08 Jun 2007 09:34:37 +0800 [thread overview]
Message-ID: <1181266477.3039.97.camel@debian.sh.intel.com> (raw)
In-Reply-To: <20070607223058.44122be4@griffin.suse.cz>
On Thu, 2007-06-07 at 22:30 +0200, Jiri Benc wrote:
> > +#define SET_TSINFO_SCHEDULE(i, d) (i.byte3 |= (d << 0) & 0x01)
>
> Please add IEEE80211_ prefix here as well. For consistency and not
> polluting a name space.
Point accepted.
> > +enum wifi_oui_stype_wmm {
> > + WIFI_OUI_STYPE_WMM_INFO = 0,
> > + WIFI_OUI_STYPE_WMM_PARAM = 1,
> > + WIFI_OUI_STYPE_WMM_TSPEC = 2,
> > +};
>
> Please don't invent new useless prefixes. Also, a registered trademark
> doesn't seem to be a good prefix.
I think we have talked this early and now you know correctly WIFI is not
a trademark. You define IEEE80211_STYPE_ASSOC_REQ, etc, but defines
those for Wi-Fi with WLAN prefix? WLAN prefix should be used by symbols
defined by mac80211, for example: WLAN_CAPABILITY_ESS.
Thanks,
-yi
next prev parent reply other threads:[~2007-06-08 1:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 8:22 [PATCH 1/3] mac80211: add IEEE802.11e/WMM structures Zhu Yi
2007-06-07 20:30 ` Jiri Benc
2007-06-08 1:34 ` Zhu Yi [this message]
2007-06-08 7:23 ` Johannes Berg
2007-06-08 10:07 ` Jiri Benc
2007-06-08 4:32 ` jketreno
2007-06-07 22:49 ` Jiri Benc
2007-06-07 22:59 ` Jouni Malinen
2007-06-08 2:14 ` Michael Wu
2007-06-08 3:40 ` Zhu Yi
2007-06-08 10:16 ` Jiri Benc
2007-06-08 16:38 ` Zhu Yi
-- strict thread matches above, loose matches on Subject: below --
2007-05-25 11:52 Zhu Yi
2007-05-14 5:15 Zhu Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181266477.3039.97.camel@debian.sh.intel.com \
--to=yi.zhu@intel.com \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).