From: Johannes Berg <johannes@sipsolutions.net>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-wireless@vger.kernel.org, akpm <akpm@linux-foundation.org>,
jbenc@suse.cz, flamingice@sourmilk.net, Zhu Yi <yi.zhu@intel.com>
Subject: Re: [PATCH -mm] mac80211: fix 1-bit bitfield to unsigned
Date: Fri, 08 Jun 2007 10:21:36 +0200 [thread overview]
Message-ID: <1181290896.6533.16.camel@johannes.berg> (raw)
In-Reply-To: <1181290254.6533.11.camel@johannes.berg>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
On Fri, 2007-06-08 at 10:10 +0200, Johannes Berg wrote:
> Very interesting. We were wondering why the latest git tree doesn't show
> tons of endianness warnings, but it appears that when sparse finds these
> dubious bitfields it turns off all other warnings.
>
> Zhu Yi, can you apply this patch to your tree and review your code and
> the sparse output and stick le16_to_cpu()/le32_to_cpu() into the
> appropriate places? A whole bunch of things there are endianness broken
> and sparse probably only gives you an approximation of what errors there
> are.
Oh, forgot to mention you need to run
make C=2 CHECKFLAGS="-D__CHECK_ENDIAN__" M=net/mac80211/
(if you weren't aware already.)
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
prev parent reply other threads:[~2007-06-08 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 22:02 [PATCH -mm] mac80211: fix 1-bit bitfield to unsigned Randy Dunlap
2007-06-08 8:10 ` Johannes Berg
2007-06-08 8:21 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1181290896.6533.16.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=akpm@linux-foundation.org \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox