Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Andy Green <andy@warmcat.com>
Cc: Jiri Benc <jbenc@suse.cz>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [WIP] mac80211: kill mgmt interface
Date: Sat, 23 Jun 2007 23:48:33 +0200	[thread overview]
Message-ID: <1182635313.21939.122.camel@johannes.berg> (raw)
In-Reply-To: <467CE130.2080306@warmcat.com>

[-- Attachment #1: Type: text/plain, Size: 2702 bytes --]

On Sat, 2007-06-23 at 10:00 +0100, Andy Green wrote:
> Johannes Berg wrote:
> 
> > On the other hand, I do consider userspace MLME needs slightly
> > different; it needs to be able to have frames encrypted, needs to see
> > frames that have been decrypted even though they would otherwise be
> > dropped [and this is very different to what you want], and probably
> > more.
> 
> Fair enough, but injection is a separate issue from RX, despite one
> usually needs both.  That there is no standard way to inject on
> mac80211, regardless of the RX situation is a major lack.  If injection
> is not treated as a separate valid action then it will constantly be
> delayed as part of some larger effort, when it is valuable in itself.

Don't get me wrong, I fully support your patches. I can see usefulness
in what you're doing there, I even based my recent patch-frenzy on top
of your patches ;) But I'm not fully convinced that this will be the
best path for the userspace MLME (in whatever form); I do however think
that it is the best option for wireless analysis/hacking/... tools or
something like your penumbra.

> But Jiri's encapsulation method is an improvement if it can be
> implemented okay for unassociated interfaces and so on.

Not convinced; it solves only a minor part of the problem, the hard
things aren't solved (like that we need to see the decrypted frames that
would normally be dropped by the kernel). Hence, I don't see any value
in it by itself without solving the harder parts as well (or better even
first), when solving that may end up using netlink for frames anyway.

> I don't have anything against it, but for me the packets I am injecting
> are normal network traffic and sending them like that seems the most
> natural way.  For RX down in userspace it is marginally simpler to use
> libpcap monitoring and the same handle for injection and rx.

Right; I see that your situation wildly differs from the userspace MLME
and that in that situation this is the best and easiest thing to do.

>  I
> definitely think having two paths to injection is not necessary, but for
> splitting out normally invisible management packets to go down a
> separate netlink socket instead of encapsulating them I don't mind
> either way.

I think what we need to accept is that the long-touted concept of a
"userspace MLME" isn't really that, while it's dead simple to do
*everything* in userspace by using a monitor interface with injection
and then a tun interface that isn't really what we want. We want to push
parts of the complexity to userspace while still having it
kernel-assisted for various reasons like performance.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

  reply	other threads:[~2007-06-23 21:47 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-21  9:42 [WIP] mac80211: kill mgmt interface Johannes Berg
2007-06-21 12:35 ` Jiri Benc
2007-06-21 12:45   ` Johannes Berg
2007-06-21 13:14     ` Jiri Benc
2007-06-21 23:27       ` Andy Green
2007-06-22 13:45       ` Jiri Benc
2007-06-22 14:29         ` Andy Green
2007-06-22 15:30           ` Johannes Berg
2007-06-22 15:49             ` Jiri Benc
2007-06-22 20:20               ` Johannes Berg
2007-06-23  5:58                 ` Andy Green
2007-06-23  6:53                   ` Johannes Berg
2007-06-23  9:00                     ` Andy Green
2007-06-23 21:48                       ` Johannes Berg [this message]
2007-06-24  8:51                         ` Andy Green
2007-06-24  9:38                           ` Johannes Berg
2007-06-23 11:44                     ` Jiri Benc
2007-06-23 12:23                       ` Andy Green
2007-06-23 21:51                         ` Johannes Berg
2007-06-24  8:39                           ` Andy Green
2007-06-24 10:46                             ` Jiri Benc
2007-06-22 15:39           ` Jiri Benc
2007-06-22 17:00             ` Andy Green
2007-06-23  8:29               ` Andy Green
2007-06-23 21:41                 ` Johannes Berg
2007-06-21 13:35 ` Jouni Malinen
2007-06-22  5:05   ` Michael Wu
2007-06-22 10:12     ` Johannes Berg
2007-06-23  7:08   ` Johannes Berg
  -- strict thread matches above, loose matches on Subject: below --
2007-06-21 21:50 Joerg Pommnitz
2007-06-22  9:10 ` Johannes Berg
2007-06-22 13:15 ` Jiri Benc
2007-07-01  1:48   ` Cohen, Guy
2007-07-02 13:38 AW: " Joerg Pommnitz
2007-07-02 13:53 ` Jiri Benc
2007-07-04  6:13   ` Tomas Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1182635313.21939.122.camel@johannes.berg \
    --to=johannes@sipsolutions.net \
    --cc=andy@warmcat.com \
    --cc=jbenc@suse.cz \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox