From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Michael Buesch <mb@bu3sch.de>, Jiri Benc <jbenc@suse.cz>,
John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Export short-preamble bit to drivers
Date: Thu, 28 Jun 2007 11:57:00 +0200 [thread overview]
Message-ID: <1183024620.4769.80.camel@johannes.berg> (raw)
In-Reply-To: <200706271840.09719.flamingice@sourmilk.net>
[-- Attachment #1: Type: text/plain, Size: 670 bytes --]
On Wed, 2007-06-27 at 18:40 -0700, Michael Wu wrote:
> On Monday 25 June 2007 07:28, Michael Buesch wrote:
> > +#define IEEE80211_CONF_SHORT_PREAMBLE (1<<3) /* use short preamble
> > + * with IEEE 802.11b */
> Shouldn't this be more of a "short preamble allowed" bit rather than "use
> short preamble"? After all, short preamble is usually configured per frame.
I don't think we ever care about configuring it per-frame and currently
can't afaik, so I don't think we can rightfully say "short preamble
allowed" unless we want to confuse driver authors about who is
responsible for then determining whether to use it or not for each
frame.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-06-28 9:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-25 14:28 [PATCH] mac80211: Export short-preamble bit to drivers Michael Buesch
2007-06-27 8:55 ` Johannes Berg
2007-06-27 13:08 ` Michael Buesch
2007-06-27 14:30 ` Johannes Berg
2007-06-27 14:37 ` Michael Buesch
2007-06-27 13:33 ` Michael Buesch
2007-06-27 13:58 ` Johannes Berg
2007-06-28 1:40 ` Michael Wu
2007-06-28 8:35 ` Michael Buesch
2007-06-28 9:57 ` Johannes Berg [this message]
2007-06-29 6:01 ` Michael Wu
2007-06-29 6:07 ` Johannes Berg
2007-06-29 8:13 ` Michael Buesch
2007-06-29 22:39 ` Daniel Drake
2007-06-30 12:47 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183024620.4769.80.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).