From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Andy Green <andy@warmcat.com>
Subject: Re: [PATCH] mac80211: separate monitor/subif_start_xmit
Date: Fri, 29 Jun 2007 07:58:49 +0200 [thread overview]
Message-ID: <1183096729.4089.7.camel@johannes.berg> (raw)
In-Reply-To: <200706282235.46522.flamingice@sourmilk.net>
[-- Attachment #1: Type: text/plain, Size: 620 bytes --]
On Thu, 2007-06-28 at 22:35 -0700, Michael Wu wrote:
> On Thursday 21 June 2007 06:39, Johannes Berg wrote:
> > + skb_set_network_header(skb, len + sizeof(struct ieee80211_hdr));
> > + skb_set_transport_header(skb, len + sizeof(struct ieee80211_hdr));
> > +
> Hm, just noticed a potential problem with this. sizeof(struct ieee80211_hdr)
> can't be used since ieee80211 headers are variable sized and the smallest
> frames can end up being smaller than the 4 addr header.
Uh, let me think, yeah sounds about right, we'll have to get the actual
header length. There's a function for that though.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
prev parent reply other threads:[~2007-06-29 5:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-21 13:39 [PATCH] mac80211: separate monitor/subif_start_xmit Johannes Berg
2007-06-29 5:35 ` Michael Wu
2007-06-29 5:39 ` Michael Wu
2007-06-29 5:47 ` Michael Wu
2007-06-29 5:58 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1183096729.4089.7.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=andy@warmcat.com \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox