From: Pavel Roskin <proski@gnu.org>
To: Jiri Benc <jbenc@suse.cz>
Cc: linux-wireless@vger.kernel.org, Guido Guenther <agx@sigxcpu.org>,
at76c503a-develop@lists.berlios.de
Subject: Re: at76_usb - fourth submission attempt
Date: Thu, 12 Jul 2007 14:39:07 -0400 [thread overview]
Message-ID: <1184265547.29486.2.camel@dv> (raw)
In-Reply-To: <20070712201702.72209493@griffin.suse.cz>
On Thu, 2007-07-12 at 20:17 +0200, Jiri Benc wrote:
> Could you send a direct pointer to the patch? And make a patch that
> creates those at76_usb* files in the correct dir by itself? That will
> ease the review a lot.
http://80211libre.org/at76/at76_usb_try4.patch
Individual files are in http://80211libre.org/at76/
> > The biggest change that has not been done is conversion to mac80211. I
> > believe it's possible, but I don't expect it to happen overnight. Until
> > then, at76_usb uses its own implementation of 802.11 protocol.
>
> Unfortunately, that prevents being accepted to vanilla.
>
> I'd suggest to convert the driver to mac80211 and submit it then;
> otherwise people will tend to look at the code saying "NAK, it contains
> its own home grown 802.11 stack" only and not to review the driver in
> depth.
Well, that make sense. Helpers are welcome :)
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2007-07-12 18:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-12 8:16 at76_usb - fourth submission attempt Pavel Roskin
2007-07-12 10:00 ` Johannes Berg
2007-07-12 18:17 ` Jiri Benc
2007-07-12 18:39 ` Pavel Roskin [this message]
2007-08-23 20:58 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1184265547.29486.2.camel@dv \
--to=proski@gnu.org \
--cc=agx@sigxcpu.org \
--cc=at76c503a-develop@lists.berlios.de \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox