From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] wifi: rtw88: Don't use static local variable in rtw8822b_set_tx_power_index_by_rate
Date: Mon, 27 Jan 2025 06:03:03 +0000 [thread overview]
Message-ID: <11853ea27d7b4789b18557e44ef3e62a@realtek.com> (raw)
In-Reply-To: <8a60f581-0ab5-4d98-a97d-dd83b605008f@gmail.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
>
> Some users want to plug two identical USB devices at the same time.
> This static variable could theoretically cause them to use incorrect
> TX power values.
>
> Move the variable to the caller and pass a pointer to it to
> rtw8822b_set_tx_power_index_by_rate().
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
By the way, if you interest to cleanup rtw88 and avoid this kind of limits,
we can check symbols of output of "objdump -t *.o | grep "\.data".
Patches are welcome.
next prev parent reply other threads:[~2025-01-27 6:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-26 14:03 [PATCH 1/2] wifi: rtw88: Don't use static local variable in rtw8822b_set_tx_power_index_by_rate Bitterblue Smith
2025-01-26 14:04 ` [PATCH 2/2] wifi: rtw88: Don't use static local variable in rtw8821c_set_tx_power_index_by_rate Bitterblue Smith
2025-01-27 6:04 ` Ping-Ke Shih
2025-01-27 6:03 ` Ping-Ke Shih [this message]
2025-01-27 23:17 ` [PATCH 1/2] wifi: rtw88: Don't use static local variable in rtw8822b_set_tx_power_index_by_rate Bitterblue Smith
2025-02-03 2:43 ` Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11853ea27d7b4789b18557e44ef3e62a@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox