From: Johannes Berg <johannes@sipsolutions.net>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] nl80211: fix a bug caused by a missing asterisk
Date: Sat, 11 Aug 2007 10:21:32 +0200 [thread overview]
Message-ID: <1186820492.5363.4.camel@johannes.berg> (raw)
I really dislike double pointers. Oh well.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
Just hit it yesterday, oopses the kernel under RNTL so you're screwed.
Not nice.
--- wireless-dev.orig/net/wireless/nl80211.c 2007-08-11 10:19:57.999563528 +0200
+++ wireless-dev/net/wireless/nl80211.c 2007-08-11 10:19:58.559563528 +0200
@@ -55,7 +55,7 @@ static int get_drv_dev_by_info_ifindex(s
ifindex = nla_get_u32(info->attrs[NL80211_ATTR_IFINDEX]);
*dev = dev_get_by_index(ifindex);
- if (!dev)
+ if (!*dev)
return -ENODEV;
*drv = cfg80211_get_dev_from_ifindex(ifindex);
reply other threads:[~2007-08-11 8:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186820492.5363.4.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox