From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] mac80211: remove management interface
Date: Tue, 14 Aug 2007 13:42:46 +0200 [thread overview]
Message-ID: <1187091766.4069.5.camel@johannes.berg> (raw)
In-Reply-To: <200708130844.27516.flamingice@sourmilk.net>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
On Mon, 2007-08-13 at 08:44 -0700, Michael Wu wrote:
> On Monday 13 August 2007 00:45, Johannes Berg wrote:
> > Oh and somebody needs to fix zd1211rw-mac80211. It abused the
> > MGMT interface constant that was explicitly mentioned to be
> > not for drivers... I've "fixed" it for now but readers of the
> > code may not be happy with it.
> I've done this in all my drivers. It's perfectly fine. If you're going to drop
> the MGMT enum, please post a patch to s/IEEE80211_IF_TYPE_MGMT/-1/ for all
> drivers.
Oh, I thought zd1211 was the only one doing that. I could add a
IF_TYPE_INVALID if you really require that, but I don't see the point.
As soon as the driver wants to work with multiple interfaces this stuff
has to go anyway.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-08-14 11:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-13 7:45 [PATCH 0/3] management interface removal Johannes Berg
2007-08-13 7:45 ` [PATCH 1/3] mac80211: allow tx handlers on injected packets Johannes Berg
2007-08-13 7:45 ` [PATCH 2/3] mac80211: refactor event sending Johannes Berg
2007-08-13 7:45 ` [PATCH 3/3] mac80211: remove management interface Johannes Berg
2007-08-13 7:55 ` Johannes Berg
2007-08-13 15:44 ` Michael Wu
2007-08-14 11:42 ` Johannes Berg [this message]
2007-08-14 12:21 ` Ivo van Doorn
2007-08-14 12:42 ` [PATCH v2] " Johannes Berg
2007-08-14 13:17 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187091766.4069.5.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).