From: Johannes Berg <johannes@sipsolutions.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: [PATCH] nl80211: remove VLAN type
Date: Wed, 15 Aug 2007 11:18:37 +0200 [thread overview]
Message-ID: <1187169518.3960.0.camel@johannes.berg> (raw)
There is no point in trying to handle source MAC address based VLANs in
the wireless stack, something like "smacvlan" modeled after macvlan
should be sufficient.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
We could just not keep the hole as well since people can't really be
using that header yet, but the version we have in previous kernels could
still be shipped somewhere so I think it should be kept compatible.
include/linux/nl80211.h | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
--- wireless-dev.orig/include/linux/nl80211.h 2007-08-15 00:43:06.290200043 +0200
+++ wireless-dev/include/linux/nl80211.h 2007-08-15 00:45:51.860200043 +0200
@@ -207,7 +207,6 @@ enum nl80211_attrs {
* @NL80211_IFTYPE_ADHOC: independent BSS member
* @NL80211_IFTYPE_STATION: managed BSS member
* @NL80211_IFTYPE_AP: access point
- * @NL80211_IFTYPE_AP_VLAN: VLAN interface for access points
* @NL80211_IFTYPE_WDS: wireless distribution interface
* @NL80211_IFTYPE_MONITOR: monitor interface receiving all frames
* @__NL80211_IFTYPE_AFTER_LAST: internal use
@@ -217,13 +216,17 @@ enum nl80211_attrs {
*
*/
enum nl80211_iftype {
- NL80211_IFTYPE_UNSPECIFIED,
- NL80211_IFTYPE_ADHOC,
- NL80211_IFTYPE_STATION,
- NL80211_IFTYPE_AP,
- NL80211_IFTYPE_AP_VLAN,
- NL80211_IFTYPE_WDS,
- NL80211_IFTYPE_MONITOR,
+ NL80211_IFTYPE_UNSPECIFIED = 0,
+ NL80211_IFTYPE_ADHOC = 1,
+ NL80211_IFTYPE_STATION = 2,
+ NL80211_IFTYPE_AP = 3,
+ /*
+ * there was AP_VLAN here but it was never used
+ * keep the number unallocated for the benefit
+ * of those people using old headers
+ */
+ NL80211_IFTYPE_WDS = 5,
+ NL80211_IFTYPE_MONITOR = 6,
/* keep last */
__NL80211_IFTYPE_AFTER_LAST
next reply other threads:[~2007-08-15 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-15 9:18 Johannes Berg [this message]
2007-08-16 15:03 ` [PATCH] nl80211: remove VLAN type Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187169518.3960.0.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox