From: Johannes Berg <johannes@sipsolutions.net>
To: linux-wireless@vger.kernel.org
Subject: Re: retry count?
Date: Wed, 15 Aug 2007 11:27:08 +0200 [thread overview]
Message-ID: <1187170028.3960.2.camel@johannes.berg> (raw)
In-Reply-To: <1186914007.5363.9.camel@johannes.berg>
[-- Attachment #1: Type: text/plain, Size: 572 bytes --]
On Sun, 2007-08-12 at 12:20 +0200, Johannes Berg wrote:
> struct ieee80211_tx_status contains "retry_count" and I just noticed
> that bcm43xx sets it to -1 if the frame was acked right away. Should it
> be -1 in that case or should it be 0? A comment indicating either way
> would be good. If it should be -1, then I suppose the radiotap tx status
> needs to be fixed, it defines data_retries as a u8 so can't really be
> less than 0.
Turns out that was wrong and b43 used to set it to -1 when the frame
wasn't transmitted at all due to some error.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
prev parent reply other threads:[~2007-08-15 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-12 10:20 retry count? Johannes Berg
2007-08-15 9:27 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187170028.3960.2.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox