From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
Jiri Benc <jbenc@suse.cz>, Michael Wu <flamingice@sourmilk.net>,
Daniel Drake <dsd@gentoo.org>
Subject: Re: [RFC] the recently discussed flags patch
Date: Wed, 15 Aug 2007 12:38:02 +0200 [thread overview]
Message-ID: <1187174282.3998.0.camel@johannes.berg> (raw)
In-Reply-To: <200708141848.57809.mb@bu3sch.de>
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
On Tue, 2007-08-14 at 18:48 +0200, Michael Buesch wrote:
> Please some more comments on what they actually mean
> and what's usually to do when the flag is set.
Will do.
> > + /* Change filter flags, see above for FIF_* constants.
> > + *
> > + * Must be atomic due to running under the tx lock.
> > + * This callback is required.
> > + */
> > + void (*change_filter_flags)(struct ieee80211_hw *hw,
> > + int changed_flags, int total_flags);
>
> Better use unsigned int.
Yeah, did that.
> What does changed_flags and total_flags mean?
> I thought we'd like to have a pointer here, to the driver
> can clear what's not supported.
I changed that in the second version, and changed_flags indicates which
ones have changed since the last call so the driver need not set all of
them if that might be expensive.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
next prev parent reply other threads:[~2007-08-15 10:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-14 16:21 [RFC] the recently discussed flags patch Johannes Berg
2007-08-14 16:48 ` Michael Buesch
2007-08-15 10:38 ` Johannes Berg [this message]
2007-08-14 22:56 ` Johannes Berg
2007-08-15 10:54 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187174282.3998.0.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=dsd@gentoo.org \
--cc=flamingice@sourmilk.net \
--cc=jbenc@suse.cz \
--cc=linux-wireless@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).