Re: [PATCH] hostapd: don't reference ieee80211_msg_sta_not_assoc if it's unused anyway

[Johannes Berg <johannes@sipsolutions.net>]

[-- Attachment #1: Type: text/plain, Size: 1433 bytes --]

On Tue, 2007-08-14 at 20:40 -0700, Jouni Malinen wrote:
> On Fri, Aug 10, 2007 at 11:38:01PM +0200, Johannes Berg wrote:
> > Hostapd doesn't do anything about such frames. Kernel no longer sends
> > them and the constant was removed, so let's not reference it any longer..
> 
> This is not good.. We should really make sure that deauth/disassoc is
> sent out at proper time to avoid clients getting stuck believing that
> they are associated.

I know we should, but I regard this as a bit of a chicken and egg
problem. Right now, hostapd doesn't care, but the kernel sends those
notifications. So I could remove it from the kernel without anybody ever
noticing.

> Why does the kernel no longer send this notification? The current
> wireless-dev.git seems to have this still in use and as such, I have not
> applied this change into hostapd and would rather not apply it either,
> i.e., if there is some need for getting rid of
> ieee80211_msg_sta_not_assoc, I would like to see it being done by
> providing similar functionality by some other means, not by just
> removing this.

The reason for removing all the ieee80211_msg_* constants is that I'd
really love to be able to get rid of the prism2 header hack in there. By
removing it from both sides I've only slightly extended the TODO from
"fix this in hostapd" to "add API to the kernel and use it in hostapd"
which I thought appropriate.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]