From: Joe Perches <joe@perches.com>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: Daniel Drake <dsd@gentoo.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Ulrich Kunitz <kune@deine-taler.de>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver
Date: Thu, 30 Aug 2007 15:19:53 -0700 [thread overview]
Message-ID: <1188512393.6062.156.camel@localhost> (raw)
In-Reply-To: <9a8748490708301320o49d8e794vc5c37ffc938006f1@mail.gmail.com>
On Thu, 2007-08-30 at 22:20 +0200, Jesper Juhl wrote:
> Ok, I must admit I didn't check with sparse since it seemed pointless
> - we usually never cast void pointers to other pointer types,
> specifically because the C language nicely guarantees that the right
> thing will happen without the cast. Sometimes we have to cast them to
> integer types, su sure we need the cast there. But what on earth
> makes a "zd_addr_t *" so special that we have to explicitly cast a
> "void *" to that type?
http://marc.info/?l=linux-netdev&m=117113743902549&w=1
next prev parent reply other threads:[~2007-08-30 22:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1554af80879a7ef2f78a4d654f23c248203500d9.1187912217.git.jesper.juhl@gmail.com>
2007-08-24 0:03 ` [PATCH 14/30] net: Kill some unneeded allocation return value casts in libertas Jesper Juhl
2007-08-24 15:50 ` Dan Williams
[not found] ` <d551047daed1cb4d9de1eff956268a468c9837f6.1187912217.git.jesper.juhl@gmail.com>
2007-08-30 17:54 ` [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver Daniel Drake
2007-08-30 20:20 ` Jesper Juhl
2007-08-30 22:19 ` Joe Perches [this message]
2007-08-30 22:30 ` [PATCH] Don't needlessly initialize variable to NULL in zd_chip (was: Re: [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver) Jesper Juhl
2007-08-30 22:42 ` Randy Dunlap
2007-08-30 23:04 ` Jesper Juhl
2007-08-30 23:47 ` [PATCH 13/30] net: Don't do pointless kmalloc return value casts in zd1211 driver Daniel Drake
2007-08-31 9:30 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188512393.6062.156.camel@localhost \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=dsd@gentoo.org \
--cc=jesper.juhl@gmail.com \
--cc=kune@deine-taler.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox