Re: [PATCH V3] Add iwlwifi wireless drivers

Ivo van Doorn
2007-09-04T18:05:40Z

On Tuesday 04 September 2007, dragoran wrote:
> >+static ssize_t show_rf_kill(struct device *d,
> >+ struct device_attribute *attr, char *buf)
> >+{
> >+ /*
> >+ * 0 - RF kill not enabled
> >+ * 1 - SW based RF kill active (sysfs)
> >+ * 2 - HW based RF kill active
> >+ * 3 - Both HW and SW based RF kill active
> >
> >that as well, along with all the other sysfs bits. Also, how about using
> >the generic rfkill infrastructure Ivo did?
>
> is the generic rfkill interface already stable and merged into the linus tree?

Yes. It currently is only missing users.

> if not please leave this for now to not break userspace (hal).
> hal currently is using this on all ipw* and iwl* drivers to get and
> set the rfkill status. And NM uses this interface to set/get rfkill
> status.
>
> So please don't remove this yet until the proper interface is merged
> too (which should be better anyway because this one requires polling)

The input-polldev interface could be used for polling if it is required.

Ivo