From: Pavel Roskin <proski@gnu.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-wireless@vger.kernel.org,
"Luis R. Rodriguez" <mcgrof@gmail.com>
Subject: Re: API to regulatory control (1)
Date: Mon, 24 Sep 2007 09:24:13 -0400 [thread overview]
Message-ID: <1190640253.21374.14.camel@dv> (raw)
In-Reply-To: <1190639518.18521.269.camel@johannes.berg>
On Mon, 2007-09-24 at 15:11 +0200, Johannes Berg wrote:
> > > Please consider using "long" for hardware_value. Drivers should be able
> > > to use this value as a pointer to some driver-specific structure.
> >
> > If you want to use it as pointer better make it a pointer..
>
> Then we'd have to have two values. I don't see a need for having a
> pointer at all though. Pavel, can you show a driver that really benefits
> from that? And explain why it can't use an array index here?
No, it's just a "general sanity" thing. If we want the driver to keep
some data there without specifying what data it can be, it's better to
provide a way to keep a pointer if needed.
OK, if my suggestion doesn't sound interesting, we can forget it for
now. After all, it's easy to change Linux code at any time, as long as
the external interfaces are not involved.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2007-09-24 13:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 10:22 API to regulatory control (1) Johannes Berg
2007-09-22 10:32 ` API to regulatory control (2) Johannes Berg
2007-09-22 16:33 ` Luis R. Rodriguez
2007-09-24 8:43 ` Johannes Berg
2007-09-22 21:16 ` API to regulatory control (1) Luis R. Rodriguez
2007-09-24 9:02 ` Johannes Berg
2007-09-24 19:55 ` Luis R. Rodriguez
2007-09-24 21:36 ` Johannes Berg
2007-09-24 22:18 ` Luis R. Rodriguez
2007-09-25 13:40 ` Johannes Berg
2007-09-25 16:13 ` Luis R. Rodriguez
2007-09-25 16:23 ` Johannes Berg
2007-09-24 12:59 ` Pavel Roskin
2007-09-24 13:07 ` Christoph Hellwig
2007-09-24 13:11 ` Johannes Berg
2007-09-24 13:24 ` Pavel Roskin [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-09-25 14:43 Joerg Pommnitz
2007-09-25 15:11 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190640253.21374.14.camel@dv \
--to=proski@gnu.org \
--cc=hch@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).