From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: Michael Buesch <mb@bu3sch.de>,
Ulrich Kunitz <kune@deine-taler.de>,
Daniel Drake <dsd@gentoo.org>,
linux-wireless@vger.kernel.org,
John Linville <linville@tuxdriver.com>
Subject: Re: zd1211 config operation problem
Date: Mon, 24 Sep 2007 21:26:55 +0200 [thread overview]
Message-ID: <1190662015.18521.280.camel@johannes.berg> (raw)
In-Reply-To: <200709241520.50411.flamingice@sourmilk.net>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Mon, 2007-09-24 at 15:20 -0400, Michael Wu wrote:
> On Monday 24 September 2007 13:20, Johannes Berg wrote:
> > On Mon, 2007-09-24 at 18:41 +0200, Michael Buesch wrote:
> > > - if (local->ops->config)
> > > + if (local->open_count)
> > > ret = local->ops->config(local_to_hw(local), &local->hw.conf);
> > Isn't this racy?
> >
> Shouldn't be. Some callers are holding rtnl (ieee80211_open,
> ieee80211_ioctl*). Other callers (in ieee80211_sta.c) cannot run if the
> device is down.
Good point. I guess the patch is fine then.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]
prev parent reply other threads:[~2007-09-24 19:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-23 14:48 zd1211 config operation problem Michael Buesch
2007-09-23 15:47 ` Ulrich Kunitz
2007-09-23 17:48 ` Michael Wu
2007-09-24 16:41 ` Michael Buesch
2007-09-24 17:20 ` Johannes Berg
2007-09-24 17:21 ` Johannes Berg
2007-09-24 19:22 ` Michael Wu
2007-09-24 19:29 ` Johannes Berg
2007-09-24 19:58 ` Michael Buesch
2007-09-24 19:20 ` Michael Wu
2007-09-24 19:26 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190662015.18521.280.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=dsd@gentoo.org \
--cc=flamingice@sourmilk.net \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).