From: Johannes Berg <johannes@sipsolutions.net>
To: Michael Wu <flamingice@sourmilk.net>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] rtl8187: remove NICMAC setting in configure_filters callback
Date: Fri, 12 Oct 2007 22:53:43 +0200 [thread overview]
Message-ID: <1192222423.4770.84.camel@johannes.berg> (raw)
In-Reply-To: <20071012204512.13393.84281.stgit@magic.sourmilk.net> (sfid-20071012_214915_385291_FE84E4EB)
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
On Fri, 2007-10-12 at 16:45 -0400, Michael Wu wrote:
> @@ -602,8 +600,6 @@ static void rtl8187_configure_filter(struct ieee80211_hw *dev,
> if (mc_count > 0)
> priv->rx_conf |= RTL818X_RX_CONF_MULTICAST;
>
> - if (priv->rx_conf & RTL818X_RX_CONF_NICMAC)
> - *total_flags |= FIF_PROMISC_IN_BSS;
Does this mean you're always operating promiscuously, or was this a bug?
If the latter, do you not support promisc at all? Or should the FIF flag
always be set?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2007-10-12 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-12 20:45 [PATCH] rtl8187: remove NICMAC setting in configure_filters callback Michael Wu
2007-10-12 20:53 ` Johannes Berg [this message]
2007-10-12 20:59 ` Michael Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1192222423.4770.84.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox