From: Johannes Berg <johannes@sipsolutions.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, flamingice@sourmilk.net
Subject: Re: [RFC] mac80211: no missing key complaint if frame may not be for us
Date: Wed, 24 Oct 2007 11:00:55 +0200 [thread overview]
Message-ID: <1193216455.5715.2.camel@johannes.berg> (raw)
In-Reply-To: <1193175981828-git-send-email-linville@tuxdriver.com> (sfid-20071023_230945_570294_0AD8EAEA)
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Tue, 2007-10-23 at 17:46 -0400, John W. Linville wrote:
> + /* if there are multiple SSIDs on this BSSID, the frame may
> + not be for us anyway; so, check that either the frame is
> + unicast or that we are not in managed mode before
> + complaining about a missing key */
> + if ((!is_multicast_ether_addr(hdr->addr1) ||
> + rx->sdata->type != IEEE80211_IF_TYPE_STA) &&
> + net_ratelimit())
I think this and the other patch looks good, though I'm not entirely
sure about the !STA test yet. I suppose though !STA means that we're in
some way an AP and then we're the only one sending real multicast
traffic.
Is it worth keeping this message at all?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
next prev parent reply other threads:[~2007-10-24 9:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 21:46 [RFC] mac80211: no missing key complaint if frame may not be for us John W. Linville
2007-10-23 21:46 ` [RFC] mac80211: no decrypt failed " John W. Linville
2007-10-24 9:00 ` Johannes Berg [this message]
2007-10-24 13:48 ` [RFC] mac80211: no missing key " John W. Linville
2007-10-25 13:25 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193216455.5715.2.camel@johannes.berg \
--to=johannes@sipsolutions.net \
--cc=flamingice@sourmilk.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).