From: Luis Carlos Cobo <luisca@cozybit.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/4] o80211s: (zd1211rw-mac80211) support for mesh interface
Date: Mon, 12 Nov 2007 15:53:19 -0800 [thread overview]
Message-ID: <1194911599.6980.107.camel@localhost> (raw)
In-Reply-To: <1194689934.7258.66.camel@johannes.berg>
On Sat, 2007-11-10 at 11:18 +0100, Johannes Berg wrote:
> > + { CR_CAM_MODE, MODE_AP_WDS},
>
> Shouldn't that depend on the interface type? I.e. set it for WDS/MESH
> but clear it for station so that the station won't ack WDS frames? OTOH,
> it may just as well ack WDS frames for itself...
Yes, it doesn't look like it does any harm.
>
> > + zd_mac_config_beacon(hw, conf->beacon);
> > + kfree_skb(conf->beacon);
> > + zd_set_beacon_interval(&mac->chip, BCN_MODE_IBSS | 100);
>
> Does that mean you're hardcoding the beacon interval here while before
> you confused me how we should handle that setting in userspace? :)
I am not sure what are you referring to... anyway, by now I think it's
fine to hard code the beacon interval, but in mac80211 instead of the
driver adding a beacon_int field to ieee80211_if_conf.
--
Luis Carlos Cobo Rus GnuPG ID: 44019B60
cozybit Inc.
next prev parent reply other threads:[~2007-11-12 23:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-10 1:37 [PATCH 4/4] o80211s: (zd1211rw-mac80211) support for mesh interface Luis Carlos Cobo
2007-11-10 10:18 ` Johannes Berg
2007-11-12 23:53 ` Luis Carlos Cobo [this message]
2007-11-13 13:14 ` Johannes Berg
2007-11-13 17:21 ` Luis Carlos Cobo
2007-11-14 12:49 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1194911599.6980.107.camel@localhost \
--to=luisca@cozybit.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).