From: Dan Williams <dcbw@redhat.com>
To: Andres Salomon <dilinger@queued.net>
Cc: libertas-dev@lists.infradead.org,
Marcelo Tosatti <marcelo@kvack.org>,
David Woodhouse <dwmw2@infradead.org>,
akpm@linux-foundation.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/4] libertas: drop useless default_fw_name variable
Date: Tue, 20 Nov 2007 17:23:14 -0500 [thread overview]
Message-ID: <1195597394.32309.3.camel@localhost.localdomain> (raw)
In-Reply-To: <20071116131157.29c7227a@ephemeral>
On Fri, 2007-11-16 at 13:11 -0500, Andres Salomon wrote:
> Signed-off-by: Andres Salomon <dilinger@debian.org>
As discussed on IRC, I'll clean this series of 4 patches up for 2.6.25
and the unified libertas namespace and resubmit. Thanks!
Dan
> ---
> drivers/net/wireless/libertas/if_usb.c | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/libertas/if_usb.c b/drivers/net/wireless/libertas/if_usb.c
> index 063572f..3cf9379 100644
> --- a/drivers/net/wireless/libertas/if_usb.c
> +++ b/drivers/net/wireless/libertas/if_usb.c
> @@ -20,9 +20,8 @@
> #define MESSAGE_HEADER_LEN 4
>
> static const char usbdriver_name[] = "usb8xxx";
> -static u8 *default_fw_name = "usb8388.bin";
>
> -static char *libertas_fw_name = NULL;
> +static char *libertas_fw_name = "usb8388.bin";
> module_param_named(fw_name, libertas_fw_name, charp, 0644);
>
> /*
> @@ -1129,10 +1128,6 @@ static int if_usb_init_module(void)
>
> lbs_deb_enter(LBS_DEB_MAIN);
>
> - if (libertas_fw_name == NULL) {
> - libertas_fw_name = default_fw_name;
> - }
> -
> ret = usb_register(&if_usb_driver);
>
> lbs_deb_leave_args(LBS_DEB_MAIN, "ret %d", ret);
prev parent reply other threads:[~2007-11-20 22:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 18:11 [PATCH 1/4] libertas: drop useless default_fw_name variable Andres Salomon
2007-11-20 22:23 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1195597394.32309.3.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=dwmw2@infradead.org \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marcelo@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox