From: Dan Williams <dcbw@redhat.com>
To: Holger Schurig <hs4233@mail.mn-solutions.de>
Cc: libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] libertas: let more than one MAC event through
Date: Tue, 27 Nov 2007 11:08:38 -0500 [thread overview]
Message-ID: <1196179718.5194.2.camel@localhost.localdomain> (raw)
In-Reply-To: <200711260935.44469.hs4233@mail.mn-solutions.de>
On Mon, 2007-11-26 at 09:35 +0100, Holger Schurig wrote:
> lbs_mac_event_disconnected() was called once and then never again
> upon a hardware MAC event.
>
> The reason was that the driver didn't clean the correct bit in the interrupt
> cause register of the chip.
>
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>
Acked-by: Dan Williams <dcbw@redhat.com>
> Index: wireless-2.6/drivers/net/wireless/libertas/if_cs.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/if_cs.c 2007-11-26 10:18:05.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/if_cs.c 2007-11-26 10:18:32.000000000 +0100
> @@ -170,7 +170,8 @@ static int if_cs_poll_while_fw_download(
> #define IF_CS_H_IC_TX_OVER 0x0001
> #define IF_CS_H_IC_RX_OVER 0x0002
> #define IF_CS_H_IC_DNLD_OVER 0x0004
> -#define IF_CS_H_IC_HOST_EVENT 0x0008
> +#define IF_CS_H_IC_POWER_DOWN 0x0008
> +#define IF_CS_H_IC_HOST_EVENT 0x0010
> #define IF_CS_H_IC_MASK 0x001f
>
> #define IF_CS_H_INT_MASK 0x00000004
prev parent reply other threads:[~2007-11-27 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 8:35 [PATCH] libertas: let more than one MAC event through Holger Schurig
2007-11-27 16:08 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1196179718.5194.2.camel@localhost.localdomain \
--to=dcbw@redhat.com \
--cc=hs4233@mail.mn-solutions.de \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox