linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] libertas: let more than one MAC event through
@ 2007-11-26  8:35 Holger Schurig
  2007-11-27 16:08 ` Dan Williams
  0 siblings, 1 reply; 2+ messages in thread
From: Holger Schurig @ 2007-11-26  8:35 UTC (permalink / raw)
  To: Dan Williams; +Cc: libertas-dev, linux-wireless

lbs_mac_event_disconnected() was called once and then never again
upon a hardware MAC event.

The reason was that the driver didn't clean the correct bit in the interrupt
cause register of the chip.

Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>

Index: wireless-2.6/drivers/net/wireless/libertas/if_cs.c
===================================================================
--- wireless-2.6.orig/drivers/net/wireless/libertas/if_cs.c	2007-11-26 10:18:05.000000000 +0100
+++ wireless-2.6/drivers/net/wireless/libertas/if_cs.c	2007-11-26 10:18:32.000000000 +0100
@@ -170,7 +170,8 @@ static int if_cs_poll_while_fw_download(
 #define IF_CS_H_IC_TX_OVER		0x0001
 #define IF_CS_H_IC_RX_OVER		0x0002
 #define IF_CS_H_IC_DNLD_OVER		0x0004
-#define IF_CS_H_IC_HOST_EVENT		0x0008
+#define IF_CS_H_IC_POWER_DOWN		0x0008
+#define IF_CS_H_IC_HOST_EVENT		0x0010
 #define IF_CS_H_IC_MASK			0x001f
 
 #define IF_CS_H_INT_MASK		0x00000004

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] libertas: let more than one MAC event through
  2007-11-26  8:35 [PATCH] libertas: let more than one MAC event through Holger Schurig
@ 2007-11-27 16:08 ` Dan Williams
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Williams @ 2007-11-27 16:08 UTC (permalink / raw)
  To: Holger Schurig; +Cc: libertas-dev, linux-wireless

On Mon, 2007-11-26 at 09:35 +0100, Holger Schurig wrote:
> lbs_mac_event_disconnected() was called once and then never again
> upon a hardware MAC event.
> 
> The reason was that the driver didn't clean the correct bit in the interrupt
> cause register of the chip.
> 
> Signed-off-by: Holger Schurig <hs4233@mail.mn-solutions.de>

Acked-by: Dan Williams <dcbw@redhat.com>

> Index: wireless-2.6/drivers/net/wireless/libertas/if_cs.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/libertas/if_cs.c	2007-11-26 10:18:05.000000000 +0100
> +++ wireless-2.6/drivers/net/wireless/libertas/if_cs.c	2007-11-26 10:18:32.000000000 +0100
> @@ -170,7 +170,8 @@ static int if_cs_poll_while_fw_download(
>  #define IF_CS_H_IC_TX_OVER		0x0001
>  #define IF_CS_H_IC_RX_OVER		0x0002
>  #define IF_CS_H_IC_DNLD_OVER		0x0004
> -#define IF_CS_H_IC_HOST_EVENT		0x0008
> +#define IF_CS_H_IC_POWER_DOWN		0x0008
> +#define IF_CS_H_IC_HOST_EVENT		0x0010
>  #define IF_CS_H_IC_MASK			0x001f
>  
>  #define IF_CS_H_INT_MASK		0x00000004


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-11-27 16:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-26  8:35 [PATCH] libertas: let more than one MAC event through Holger Schurig
2007-11-27 16:08 ` Dan Williams

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).